From: "Shawn O. Pearce" <spearce@spearce•org>
To: Lee Marlow <lee.marlow@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] bash completion: Add completion for 'git grep'
Date: Mon, 4 Aug 2008 07:53:03 -0700 [thread overview]
Message-ID: <20080804145303.GE27666@spearce.org> (raw)
In-Reply-To: <1217638593-57321-1-git-send-email-lee.marlow@gmail.com>
Lee Marlow <lee.marlow@gmail•com> wrote:
> Added completions for all long options specified in the docs
> --cached
> --text --ignore-case --word-regexp --invert-match
> --full-name
> --extended-regexp --basic-regexp --fixed-strings
> --files-with-matches --name-only
> --files-without-match
> --count
> --and --or --not --all-match
>
> Signed-off-by: Lee Marlow <lee.marlow@gmail•com>
Acked-by: Shawn O. Pearce <spearce@spearce•org>
This is the "first patch" which has the doubledash test. As you
pointed out, its better because it stops completion of long options
after the --.
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 30d8701..b28ac10 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -796,6 +796,29 @@ _git_gc ()
> COMPREPLY=()
> }
>
> +_git_grep ()
> +{
> + __git_has_doubledash && return
> +
> + local cur="${COMP_WORDS[COMP_CWORD]}"
> + case "$cur" in
> + --*)
> + __gitcomp "
> + --cached
> + --text --ignore-case --word-regexp --invert-match
> + --full-name
> + --extended-regexp --basic-regexp --fixed-strings
> + --files-with-matches --name-only
> + --files-without-match
> + --count
> + --and --or --not --all-match
> + "
> + return
> + ;;
> + esac
> + COMPREPLY=()
> +}
> +
> _git_help ()
> {
> local cur="${COMP_WORDS[COMP_CWORD]}"
> @@ -1486,6 +1509,7 @@ _git ()
> fetch) _git_fetch ;;
> format-patch) _git_format_patch ;;
> gc) _git_gc ;;
> + grep) _git_grep ;;
> help) _git_help ;;
> log) _git_log ;;
> ls-remote) _git_ls_remote ;;
> --
--
Shawn.
prev parent reply other threads:[~2008-08-04 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 0:56 [PATCH] bash completion: Add completion for 'git grep' Lee Marlow
2008-08-02 21:05 ` Shawn O. Pearce
2008-08-03 7:31 ` Lee Marlow
2008-08-04 4:06 ` Shawn O. Pearce
2008-08-04 5:26 ` Lee Marlow
2008-08-04 14:52 ` Shawn O. Pearce
2008-08-04 14:53 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080804145303.GE27666@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=lee.marlow@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox