From: "Shawn O. Pearce" <spearce@spearce•org>
To: Imran M Yousuf <imran@smartitengineering•com>
Cc: imyousuf@gmail•com, git@vger•kernel.org,
robin.rosenberg@dewire•com,
Imran M Yousuf <imyousuf@smartitengineering•com>
Subject: Re: [JGit Patch v2 5/7] Add script for adding second pack for test purpose
Date: Fri, 22 Aug 2008 09:06:51 -0700 [thread overview]
Message-ID: <20080822160651.GI3483@spearce.org> (raw)
In-Reply-To: <9e85b2570808211952sa903434lacd575388ad2d2d8@mail.gmail.com>
Imran M Yousuf <imran@smartitengineering•com> wrote:
> On Thu, Aug 21, 2008 at 9:12 PM, Shawn O. Pearce <spearce@spearce•org> wrote:
> > imyousuf@gmail•com wrote:
> >> From: Imran M Yousuf <imyousuf@smartitengineering•com>
> >>
> >> Forgot to add it last time and thus adding it before removing duplicate
> >> resources.
> >
> > I would squash this to the one that copies the other resources.
>
> I would gladly make the changes (in this patch and the other ones) if
> I am sure that this series does not break the build with Eclipse. I
> would be extremely grateful if you would please confirm this to me.
OK, so your series end result would be fine, if you squash this into
it as well. The "tst" variable is no longe rused in one location due
to the introduction of JGitTestUtil, and you missed one location that
needed to be converted from "tst" to JGitTestUtil. Otherwise the end
result looks good in Eclipse and in ./make_jgit.sh.
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
index 310690a..270b90a 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
@@ -143,7 +143,6 @@ public void run() {
"pack-9fb5b411fe6dfa89cc2e6b89d2bd8e5de02b5745",
"pack-e6d07037cbcf13376308a0a995d1fa48f8f76aaa"
};
- final File tst = new File("tst");
final File packDir = new File(db.getObjectsDirectory(), "pack");
for (int k = 0; k < packs.length; k++) {
copyFile(JGitTestUtil.getTestResourceFile(packs[k] + ".pack"), new File(packDir,
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java
index c036e79..3d81bc4 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0004_PackReader.java
@@ -41,9 +41,11 @@
import java.io.File;
import java.io.IOException;
+import org.spearce.jgit.util.JGitTestUtil;
+
public class T0004_PackReader extends RepositoryTestCase {
private static final String PACK_NAME = "pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f";
- private static final File TEST_PACK = new File(new File("tst"), PACK_NAME + ".pack");
+ private static final File TEST_PACK = JGitTestUtil.getTestResourceFile(PACK_NAME + ".pack");
private static final File TEST_IDX = new File(TEST_PACK.getParentFile(), PACK_NAME + ".idx");
public void test003_lookupCompressedObject() throws IOException {
--
Shawn.
next prev parent reply other threads:[~2008-08-22 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 3:13 [JGit Patch v2 1/7] Add a POM file for setting JGit library as a Maven project imyousuf
2008-08-21 3:13 ` [JGit Patch v2 2/7] Add test resources to a new package structured directory imyousuf
2008-08-21 3:13 ` [JGit Patch v2 3/7] Add test resources directory as a classpath entry imyousuf
2008-08-21 3:13 ` [JGit Patch v2 4/7] Use test resources from classpath imyousuf
2008-08-21 3:13 ` [JGit Patch v2 5/7] Add script for adding second pack for test purpose imyousuf
[not found] ` <1219288394-1241-6-git-send-email-imyousuf@gmail.com>
2008-08-21 3:13 ` [JGit Patch v2 7/7] Add ignore list for mavenized JGit imyousuf
2008-08-21 15:12 ` [JGit Patch v2 5/7] Add script for adding second pack for test purpose Shawn O. Pearce
2008-08-22 2:52 ` Imran M Yousuf
2008-08-22 16:06 ` Shawn O. Pearce [this message]
2008-08-23 5:21 ` Imran M Yousuf
2008-08-21 15:19 ` [JGit Patch v2 4/7] Use test resources from classpath Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080822160651.GI3483@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=imran@smartitengineering$(echo .)com \
--cc=imyousuf@gmail$(echo .)com \
--cc=imyousuf@smartitengineering$(echo .)com \
--cc=robin.rosenberg@dewire$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox