From: "Shawn O. Pearce" <spearce@spearce•org>
To: Robin Rosenberg <robin.rosenberg.lists@dewire•com>
Cc: Charles O'Farrell <charleso@charleso•org>, git@vger•kernel.org
Subject: Re: [JGIT PATCH 3/4] Added test for RefUpdate branch deletion
Date: Fri, 22 Aug 2008 16:31:49 -0700 [thread overview]
Message-ID: <20080822233149.GR3483@spearce.org> (raw)
In-Reply-To: <200808230128.19035.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire•com> wrote:
> lördagen den 23 augusti 2008 00.45.46 skrev Charles O'Farrell:
>
> Having unit tests is lovely and we appreciate that very much. We need more of this.
> Unfortunately it breaks. Is the fix the obvious one?
>
> > + public void testDeleteHead() throws IOException {
> > + final RefUpdate ref = updateRef(Constants.HEAD);
> > + delete(ref, Result.NOT_ATTEMPTED, true, false);
>
> junit.framework.AssertionFailedError: expected:<NOT_ATTEMPTED> but was:<REJECTED_CURRENT_BRANCH>
Yes. See my reply. Its already on repo.or.cz with the necessary
squashed patch.
--
Shawn.
next prev parent reply other threads:[~2008-08-22 23:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 22:45 [JGIT PATCH 0/4] Branch deletion testing and bug fixes Charles O'Farrell
2008-08-22 22:45 ` [JGIT PATCH 1/4] Ensured that RefUpdate cannot delete current branch Charles O'Farrell
2008-08-22 22:45 ` [JGIT PATCH 2/4] Fixed bug where RefUpdate didn't delete identical HEAD branch Charles O'Farrell
2008-08-22 22:45 ` [JGIT PATCH 3/4] Added test for RefUpdate branch deletion Charles O'Farrell
2008-08-22 22:45 ` [JGIT PATCH 4/4] Added extra javadoc for delete to significant RefUpdate results Charles O'Farrell
2008-08-22 23:26 ` [JGIT PATCH 3/4] Added test for RefUpdate branch deletion Shawn O. Pearce
2008-08-22 23:28 ` Robin Rosenberg
2008-08-22 23:31 ` Shawn O. Pearce [this message]
2008-08-22 23:22 ` [JGIT PATCH 1/4] Ensured that RefUpdate cannot delete current branch Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080822233149.GR3483@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=charleso@charleso$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=robin.rosenberg.lists@dewire$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox