From: David Aguilar <davvid@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: mlevedahl@gmail•com, git@vger•kernel.org
Subject: Re: [PATCH 3/3] git-submodule: add "sync" command
Date: Sun, 24 Aug 2008 12:23:44 -0700 [thread overview]
Message-ID: <20080824192343.GA22134@gmail.com> (raw)
In-Reply-To: <7vwsi6meas.fsf@gitster.siamese.dyndns.org>
On 0, Junio C Hamano <gitster@pobox•com> wrote:
> David Aguilar <davvid@gmail•com> writes:
> > + (
> > + unset GIT_DIR
> > + cd "$path"
> > + remote=$(get_remote)
> > + say "Synchronizing submodule url for '$name'"
> > + git config remote."$remote".url "$url"
>
> I am not sure about the way you determine $remote. When the HEAD in the
> submodule repository is detached by prior "git submodule update", this
> will fall back to the default "origin" --- is it a good behaviour?
>
> This is not an objection; I am merely wondering if that fallback is
> sensible, or if people who are interested in submodules can suggest better
> alternatives.
This is true. I recall there was a lengthy thread a while
back about how "origin" might not always be what you'd want
when cloning a repo. I'll address your comments, use
Mark's get_default_remote, and resend. I have a feeling that
addressing the use of remote names in submodules is beyond
the scope of this patch for now since it seems like we'd need
that info stored somewhere in a superproject gitfile.
--
David
next prev parent reply other threads:[~2008-08-24 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 17:21 git-submodule: add "sync" command (v2) David Aguilar
2008-08-24 17:21 ` [PATCH 1/3] git-submodule: add a get_remote function David Aguilar
2008-08-24 17:21 ` [PATCH 2/3] git-submodule: use get_remote in resolve_relative_url David Aguilar
2008-08-24 18:55 ` Junio C Hamano
2008-08-24 19:18 ` Junio C Hamano
2008-08-24 17:21 ` [PATCH 3/3] git-submodule: add "sync" command David Aguilar
2008-08-24 18:57 ` Junio C Hamano
2008-08-24 19:23 ` David Aguilar [this message]
2008-08-24 19:43 ` [PATCH v3] " David Aguilar
2008-08-27 8:43 ` David Aguilar
2008-08-27 17:39 ` Junio C Hamano
2008-08-24 21:29 ` [PATCH 3/3] " Mark Levedahl
2008-08-24 18:46 ` [PATCH] git-submodule - Use "get_default_remote" from git-parse-remote Mark Levedahl
2008-08-24 19:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080824192343.GA22134@gmail.com \
--to=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mlevedahl@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox