From: "Shawn O. Pearce" <spearce@spearce•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: Felipe Contreras <felipe.contreras@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] fast-import: add ignore non-existent files option.
Date: Mon, 1 Sep 2008 22:35:03 -0700 [thread overview]
Message-ID: <20080902053503.GD13248@spearce.org> (raw)
In-Reply-To: <7vfxojrvvp.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox•com> wrote:
> "Shawn O. Pearce" <spearce@spearce•org> writes:
>
> > OK, that argument makes sense. Then I wonder if more specific
> > error ignoring would be better:
> >
> > --ignore-error=already-deleted
> > --ignore-error=already-deleted,missing-mark,missing-copy-source
> >
> > I'm not really fond of turning an existing error condition that
> > exists to catch broken frontends into a generic tolerant flag.
> > But being able to selectively turn it off while leaving other
> > errors as errors isn't entirely unreasonable.
>
> I think selective loosening of consistency check makes sense very much,
> but I have been wondering if these should be command line options.
>
> The only example we saw so far is about output from one exporter. Perhaps
> it should be given to fast-import as initial set of commands ("#pragma"!)
> that describes the nature of the input file?
Yea, I briefly considered that when I added the timestamp format
option. I didn't bother because it was a single option and I figured
most frontends start git-fast-import directly. But with this being
added a "format pragrma header thingy" makes a lot of sense.
Since comments are supported we could backdoor it with #pragma or
something like that, so existing files can still be (mostly) parsed
by an earlier git-fast-import. But I wonder if that is wise given
that some classes of errors would still fail on the older import,
but would work on a newer one. Might as well just make it a proper
command that would cause an older importer to fail out of the gate.
--
Shawn.
next prev parent reply other threads:[~2008-09-02 5:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 13:20 [PATCH 1/1] fast-import: show a warning for non-existent files Felipe Contreras
2008-09-01 19:04 ` Junio C Hamano
2008-09-01 21:58 ` Felipe Contreras
2008-09-01 19:25 ` Shawn O. Pearce
2008-09-01 22:01 ` Felipe Contreras
2008-09-01 22:30 ` [PATCH] fast-import: add ignore non-existent files option Felipe Contreras
2008-09-01 22:38 ` Shawn O. Pearce
2008-09-01 22:52 ` Felipe Contreras
2008-09-02 4:39 ` Shawn O. Pearce
2008-09-02 4:53 ` Junio C Hamano
2008-09-02 5:35 ` Shawn O. Pearce [this message]
2008-09-02 7:36 ` Junio C Hamano
2008-09-02 7:48 ` Felipe Contreras
2008-09-01 23:04 ` Junio C Hamano
2008-09-01 23:25 ` Felipe Contreras
2008-09-02 2:07 ` Junio C Hamano
2008-09-02 7:57 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902053503.GD13248@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox