Subject: Re: [PATCH v3] for-each-ref: `:short` format for `refname`

From: "Shawn O. Pearce" <[email-masked]>
Date: Wed, 3 Sep 2008 08:18:29 -0700

Bert Wesarg <[email-masked]> wrote:
> Try to shorten the refname to a non-ambiguous name.
> 
> Changes in v3:
>  * don't compare sha1's, its ambiguous if the short name
>    resovles to more than one ref
>  * use xstrdup()
>  * use indexes for the loops to clarify backward/forward
>    direction
> 
> 
> Signed-off-by: Bert Wesarg <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: Shawn O. Pearce <[email-masked]>
> ---

Looks good.  But the commit messages shouldn't have the "Changes
in v3" section or probably the "Cc:" lines.  The changes in v3
part usually goes below the ---.

I don't usually work on for-each-ref, but I'll toss an ack in anyway:

Acked-by: Shawn O. Pearce <[email-masked]>

-- 
Shawn.