From: "Shawn O. Pearce" <spearce@spearce•org>
To: Jonas Fonseca <fonseca@diku•dk>
Cc: Imran M Yousuf <imyousuf@smartitengineering•com>,
Robin Rosenberg <robin.rosenberg@dewire•com>,
git@vger•kernel.org
Subject: Re: [JGIT PATCH 2/2] Move pathOf to RepositoryTestCase and use it for locating test files
Date: Wed, 3 Sep 2008 16:02:16 -0700 [thread overview]
Message-ID: <20080903230216.GI28315@spearce.org> (raw)
In-Reply-To: <20080903214818.GB6316@diku.dk>
Jonas Fonseca <fonseca@diku•dk> wrote:
> Shawn O. Pearce <spearce@spearce•org> wrote Wed, Sep 03, 2008:
> > Jonas Fonseca <fonseca@diku•dk> wrote:
> > > This is a workaround patch disguised as a cleanup patch. For NetBeans I
> > > am not yet sure how to setup JGit as a project where everythng works.
> > > For now I need to be able to override the path to files used by the
> > > tests and this patch reduces that change to one single place.
> >
> > I wonder if we shouldn't just prod Imran to finish the Maven stuff.
> > He has some patches in there that are specifically for this same
> > issue under Maven.
> >
> > http://repo.or.cz/w/egit/imyousuf.git?a=shortlog;h=refs/heads/mavenize-jgit
>
> I think the patch is a nice cleanup, even if it is a workaround. But
> anything that will help to make the build system more shell friendly is
> greatly appreciated.
Its going to cause a merge conflict with Imran's work. So I was
hoping to avoid that and just take his stuff. But if we can't wait
then yea, it is a nice cleanup patch and is worthwhile bringing in.
I'll hold onto it for about a day and see if Imran has any comment,
and merge yours if I don't hear anything tomorrow-ish.
--
Shawn.
next prev parent reply other threads:[~2008-09-03 23:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 9:10 [JGIT PATCH 2/2] Move pathOf to RepositoryTestCase and use it for locating test files Jonas Fonseca
2008-09-03 17:09 ` Shawn O. Pearce
2008-09-03 21:48 ` Jonas Fonseca
2008-09-03 23:02 ` Shawn O. Pearce [this message]
2008-09-03 23:57 ` Jonas Fonseca
2008-09-04 4:09 ` Shawn O. Pearce
2008-09-04 4:16 ` Imran M Yousuf
2008-09-04 1:47 ` Imran M Yousuf
2008-09-04 3:21 ` Shawn O. Pearce
2008-09-04 9:23 ` Jonas Fonseca
2008-09-04 10:47 ` Jakub Narebski
2008-09-04 11:17 ` Jonas Fonseca
2008-09-05 1:48 ` Imran M Yousuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080903230216.GI28315@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=fonseca@diku$(echo .)dk \
--cc=git@vger$(echo .)kernel.org \
--cc=imyousuf@smartitengineering$(echo .)com \
--cc=robin.rosenberg@dewire$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox