From: "Shawn O. Pearce" <spearce@spearce•org>
To: Petr Baudis <pasky@suse•cz>, Jonas Fonseca <fonseca@diku•dk>,
Lars Hjemli <hjemli@gmail•com>
Cc: Thomas Rast <trast@student•ethz.ch>,
Nanako Shiraishi <nanako3@lavabit•com>,
Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org
Subject: Re: [PATCH] usage.c: remove unused functions
Date: Thu, 25 Sep 2008 07:51:34 -0700 [thread overview]
Message-ID: <20080925145134.GL3669@spearce.org> (raw)
In-Reply-To: <20080925124836.GI10360@machine.or.cz>
Petr Baudis <pasky@suse•cz> wrote:
> On Thu, Sep 25, 2008 at 01:48:37PM +0200, Thomas Rast wrote:
> > Nanako Shiraishi wrote:
> > > This removes three functions that are not used anywhere.
> > [...]
> > > -void set_usage_routine(void (*routine)(const char *err) NORETURN)
> > > -void set_error_routine(void (*routine)(const char *err, va_list params))
> > > -void set_warn_routine(void (*routine)(const char *warn, va_list params))
> >
> > These blame to the following commit:
> >
> > commit 39a3f5ea7c0352a530338d30d4e618f6b4db84e4
> > Author: Petr Baudis <pasky@suse•cz>
> >
> > Customizable error handlers
...
> > So apparently the intent was that they would only be used from outside
> > Git. I don't know whether anyone still plans to do that, but they're
> > certainly not "just" unused.
>
> I don't think it will be a big deal to remove these functions, though it
> does feel like a little bit of a step backwards in the libgit efforts.
> There are some programs that already link to Git, like CGit - I wonder
> if some of them don't use them (CGit itself doesn't).
IMHO these are useless for a "libgit". However both tig and
cgit link to the non-existant libgit.a, so they may be using
these routines. I've CC'd their authors and am not applying this
particular change without an ACK from them.
--
Shawn.
next prev parent reply other threads:[~2008-09-25 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 9:41 [PATCH] usage.c: remove unused functions Nanako Shiraishi
2008-09-25 11:48 ` Thomas Rast
2008-09-25 12:48 ` Petr Baudis
2008-09-25 14:51 ` Shawn O. Pearce [this message]
2008-09-25 20:43 ` Jonas Fonseca
2008-09-29 6:35 ` Lars Hjemli
2008-09-25 12:53 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925145134.GL3669@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=fonseca@diku$(echo .)dk \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=hjemli@gmail$(echo .)com \
--cc=nanako3@lavabit$(echo .)com \
--cc=pasky@suse$(echo .)cz \
--cc=trast@student$(echo .)ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox