From: Alexander Gavrilov <angavrilov@gmail•com>
To: "Shawn O. Pearce" <spearce@spearce•org>
Cc: git@vger•kernel.org
Subject: Re: [RFC PATCH (GIT-GUI)] git-gui: Add more integration options to citool.
Date: Fri, 26 Sep 2008 14:19:40 +0400 [thread overview]
Message-ID: <200809261419.41392.angavrilov@gmail.com> (raw)
In-Reply-To: <20080924165201.GV3669@spearce.org>
On Wednesday 24 September 2008 20:52:01 Shawn O. Pearce wrote:
> Alexander Gavrilov <angavrilov@gmail•com> wrote:
> > - Make citool return nonzero exit code if it did not commit.
> > - Add a mode where it does not actually commit and simply
> > exits with zero code. Commit message is either disabled,
> > or simply dumped to GITGUI_EDITMSG before exiting.
> > - Add an option to immediately start it in amend mode.
> ...
> > I think this functionality might be useful, in particular for some of
> > my own scripts. But I'm not sure if this is the best way to do it.
>
> This looks good to me, but I think we may want to add this as a
> follow-up patch. Thoughts?
>
> --8<--
> git-gui: Hide commit related UI during citool --nocommit
>
> If the user started git-gui as "git citool --nocommit" then they
> don't need the new commit / amend commit radio buttons, or the sign
> off button in the UI. Rather than use up space with options the
> user cannot activate they are simply not installed into the UI.
>
> Signed-off-by: Shawn O. Pearce <spearce@spearce•org>
> ---
I believe that the 'Sign Off' button should better be controlled by the nocommitmsg
option; otherwise this looks good to me. But I'm not the best thinker at the
moment (had a cold).
Alexander
next prev parent reply other threads:[~2008-09-26 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 18:43 [RFC PATCH (GIT-GUI)] git-gui: Add more integration options to citool Alexander Gavrilov
2008-09-24 16:52 ` Shawn O. Pearce
2008-09-26 10:19 ` Alexander Gavrilov [this message]
2008-09-26 14:45 ` Shawn O. Pearce
2008-09-30 7:53 ` Alexander Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809261419.41392.angavrilov@gmail.com \
--to=angavrilov@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox