From: Fredrik Skolmli <fredrik@frsk•net>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Jeff King <peff@peff•net>,
Stephen Haberman <stephen@exigencecorp•com>,
gitster@pobox•com, git@vger•kernel.org
Subject: Re: [PATCH] rebase-i-p: delay saving current-commit to REWRITTEN if squashing
Date: Wed, 22 Oct 2008 17:50:14 +0200 [thread overview]
Message-ID: <20081022155014.GD20967@frsk.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0810221721370.22125@pacific.mpi-cbg.de.mpi-cbg.de>
On Wed, Oct 22, 2008 at 05:21:53PM +0200, Johannes Schindelin wrote:
> Hi,
>
> On Wed, 22 Oct 2008, Jeff King wrote:
>
> > On Wed, Oct 15, 2008 at 02:44:36AM -0500, Stephen Haberman wrote:
> >
> > > + if [ "$fast_forward" == "t" ]
> >
> > This one even fails on my Linux box. :) "==" is a bash-ism.
>
> Did we not also prefer "test" to "["?
We did.
Documentation/CodingGuidelines, line 51:
- We prefer "test" over "[ ... ]".
--
Kind regards,
Fredrik Skolmli
next prev parent reply other threads:[~2008-10-22 15:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 7:44 [PATCH] rebase-i-p: squashing and limiting todo Stephen Haberman
2008-10-15 7:44 ` [PATCH] rebase-i-p: test to exclude commits from todo based on its parents Stephen Haberman
2008-10-15 7:44 ` [PATCH] rebase-i-p: use HEAD for updating the ref instead of mapping OLDHEAD Stephen Haberman
2008-10-15 7:44 ` [PATCH] rebase-i-p: delay saving current-commit to REWRITTEN if squashing Stephen Haberman
2008-10-22 12:51 ` Jeff King
2008-10-22 15:21 ` Johannes Schindelin
2008-10-22 15:50 ` Fredrik Skolmli [this message]
2008-10-22 19:10 ` Junio C Hamano
2008-10-22 19:15 ` Jeff King
2008-10-15 7:44 ` [PATCH] rebase-i-p: fix 'no squashing merges' tripping up non-merges Stephen Haberman
2008-10-15 7:44 ` [PATCH] rebase-i-p: only list commits that require rewriting in todo Stephen Haberman
2008-10-20 11:50 ` Jeff King
2008-10-20 23:36 ` Junio C Hamano
2008-10-21 0:39 ` Jeff King
2008-10-22 5:01 ` Stephen Haberman
2008-10-22 5:48 ` Junio C Hamano
2008-10-15 7:44 ` [PATCH] rebase-i-p: do not include non-first-parent commits touching UPSTREAM Stephen Haberman
2008-10-15 7:44 ` [PATCH] rebase-i-p: if todo was reordered use HEAD as the rewritten parent Stephen Haberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022155014.GD20967@frsk.net \
--to=fredrik@frsk$(echo .)net \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=stephen@exigencecorp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox