public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Francis Galiegue <fg@one2team•net>
To: Git List <git@vger•kernel.org>
Subject: Re: [PATCH] Avoid using non-portable `echo -n` in tests.
Date: Fri, 31 Oct 2008 20:50:31 +0100	[thread overview]
Message-ID: <200810312050.31167.fg@one2team.net> (raw)

Le Friday 31 October 2008 19:39:33 Jeff King, vous avez écrit :
[...]
>
> Agreed, and actually I found such a bashism (test ==) last week (though
> of course it also broke on FreeBSD).
>

As for bash-isms, a hunt for $(...) also looks necessary...

$ grep -rl '\$([^)]\+)' $(find -type f)|wc -l
272

Unless I'm mistaken (and I probably am), the $(...) construct is 
bash-specific, isn't it?

-- 
fge

             reply	other threads:[~2008-10-31 19:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31 19:50 Francis Galiegue [this message]
2008-10-31 20:10 ` [PATCH] Avoid using non-portable `echo -n` in tests Junio C Hamano
2008-10-31 20:11 ` Ian Hilt
2008-10-31 20:30   ` Francis Galiegue
  -- strict thread matches above, loose matches on Subject: below --
2008-10-31  5:02 [PATCH] t4030: Don't use echo -n Brian Gernhardt
2008-10-31  5:09 ` [PATCH] Avoid using non-portable `echo -n` in tests Brian Gernhardt
2008-10-31  8:15   ` Junio C Hamano
2008-10-31 15:38     ` Brian Gernhardt
2008-10-31  8:20   ` Junio C Hamano
2008-10-31 14:32   ` Shawn O. Pearce
2008-10-31 18:24   ` Jeff King
2008-10-31 18:36     ` Pierre Habouzit
2008-10-31 18:39       ` Jeff King
2008-10-31 19:35         ` Francis Galiegue
2008-10-31 22:53           ` Johannes Schindelin
2008-11-03 16:30     ` Mike Ralphson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810312050.31167.fg@one2team.net \
    --to=fg@one2team$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox