public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Boyd Stephen Smith Jr." <bss03@volumehost•net>
To: Alexander Potashev <aspotashev@gmail•com>
Cc: daly@axiom-developer•org, git@vger•kernel.org
Subject: Re: builtin-add.c patch
Date: Wed, 10 Dec 2008 10:01:48 -0600	[thread overview]
Message-ID: <200812101001.53738.bss03@volumehost.net> (raw)
In-Reply-To: <20081210142632.GA4137@myhost>

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

On Wednesday 2008 December 10 08:26:32 Alexander Potashev wrote:
>> diff --git a/builtin-add.c b/builtin-add.c
>> index ea4e771..5f2e68b 100644
>> --- a/builtin-add.c
>> +++ b/builtin-add.c
>> @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec,
>> char *seen, int specs) int num_unmatched = 0, i;
>>
>>  	/*
>> -	 * Since we are walking the index as if we are warlking the directory,
>> +	 * Since we are walking the index as if we are walking the directory,
>
>We probably should use subjunctive here:
>"Since we are walking the index as if we _were_ walking the directory,".
>
>Are there any native English speakers? :)

Southern bah the grace o' gawd. :)

Yes, the subjunctive is the appropriate tense for use in hypotheticals ("as 
if").
-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss03@volumehost•net                      ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.org/                      \_/     

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-12-10 16:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-10 12:38 builtin-add.c patch daly
2008-12-10 14:26 ` Alexander Potashev
2008-12-10 16:01   ` Boyd Stephen Smith Jr. [this message]
2008-12-10 19:10   ` root
2008-12-10 22:27     ` [PATCH (resend)] Fix typo in comment in builtin-add.c Alexander Potashev
2008-12-10 23:38       ` Junio C Hamano
2008-12-10 19:14   ` builtin-add.c patch root
2008-12-10 20:10     ` Alexander Potashev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812101001.53738.bss03@volumehost.net \
    --to=bss03@volumehost$(echo .)net \
    --cc=aspotashev@gmail$(echo .)com \
    --cc=daly@axiom-developer$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox