From: "Boyd Stephen Smith Jr." <bss03@volumehost•net>
To: Jeff King <peff@peff•net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>, git@vger•kernel.org
Subject: Re: fatal output from git-show really wants a terminal
Date: Thu, 11 Dec 2008 16:45:05 -0600 [thread overview]
Message-ID: <200812111645.10067.bss03@volumehost.net> (raw)
In-Reply-To: <20081211215554.GA11565@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 2328 bytes --]
On Thursday 2008 December 11 15:55:55 Jeff King wrote:
>On Thu, Dec 11, 2008 at 10:51:15AM -0600, Boyd Stephen Smith Jr. wrote:
>> Initially, I was looking for 'stdout' or 'stderr', and found many
>> unrelated commits. I then figured it was part of the PAGER support, and
>> began
>
>Try looking for isatty, which takes the numeric fd. I think the behavior
>you asked about would be this:
Thanks, this will be plenty of context for me to be able to crawl the archives
and the actual history thinking about better behavior and considering old
discussions.
>We are not talking about
>interactivity, but rather about where the output is going. So your test
>would consider this interactive:
>
> $ git log >foo.out
>
>and start a pager, which makes no sense.
Good point, I'll try and consider that while I investgate the history of the
issue.
>Now if you proposed checking stderr and stdin _in addition_ to stdout,
>that might make more sense, but I haven't thought too hard about any
>implications.
I did see a commit message mentioning some unusual settings for PAGER, but in
general, pagers are interactive. I'd think the default behavior would
be "interactive <-> pager", with a config option to turn the pager always off
or always on. From there, I would reason the test for interactivity should
be the POSIX test.
It looks like this test have have been attempting to follow the behavior
of --color=auto to GNU less and GNU grep (and possibly others). This
certainly makes some sense as well, and may be less surprising.
>And FWIW, I don't recall this ever being discussed before, but then I
>have not been involved with git since the very beginning.
Google should be able to find it. And worst-case, I can tell wget to spider
the archives and then run some sort of find/html2txt/grep on them.
I'll go back to "the stacks" and read the discussions and commits. If my
well-informed self still thinks the behavior should change, I'll write a
patch and open up the discussion again.
--
Boyd Stephen Smith Jr. ,= ,-_-. =.
bss03@volumehost•net ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-'
http://iguanasuicide.org/ \_/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-12-11 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 16:01 fatal output from git-show really wants a terminal Tim Olsen
2008-12-10 16:10 ` Boyd Stephen Smith Jr.
2008-12-10 19:46 ` Johannes Sixt
2008-12-10 20:10 ` Tim Olsen
2008-12-10 22:24 ` Boyd Stephen Smith Jr.
[not found] ` <alpine.DEB.1.00.0812111015140.18321@eeepc-johanness>
2008-12-11 16:51 ` Boyd Stephen Smith Jr.
2008-12-11 21:55 ` Jeff King
2008-12-11 22:45 ` Boyd Stephen Smith Jr. [this message]
2008-12-11 22:59 ` Jeff King
2008-12-11 23:03 ` Junio C Hamano
2008-12-15 8:15 ` Junio C Hamano
2008-12-15 8:23 ` Junio C Hamano
2008-12-15 8:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812111645.10067.bss03@volumehost.net \
--to=bss03@volumehost$(echo .)net \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox