From: Nanako Shiraishi <nanako3@lavabit•com>
To: markus.heidelberg@web•de
Cc: "René Scharfe" <rene.scharfe@lsrfire•ath.cx>, git@vger•kernel.org
Subject: Re: [PATCH 3/3] pretty: support multiline subjects with format:
Date: Sun, 28 Dec 2008 09:09:09 +0900 [thread overview]
Message-ID: <20081228090909.6117@nanako3.lavabit.com> (raw)
In-Reply-To: <200812280024.59096.markus.heidelberg@web.de>
Quoting Markus Heidelberg <markus.heidelberg@web•de>:
>> For consistency and increased code reuse, change format: to do the
>> same as the other options.
>
> What's wrong with using the first line instead of the first paragraph
> for the other pretty options and for cases where only a small subject
> line is desired?
There were too many issues. The mail archive tells us that there were considerable discussions and thoughts behind the current behavior:
http://thread.gmane.org/gmane.comp.version-control.git/49694/focus=49922
http://thread.gmane.org/gmane.comp.version-control.git/46341/focus=46818
http://thread.gmane.org/gmane.comp.version-control.git/54020/focus=54132
http://thread.gmane.org/gmane.comp.version-control.git/21949/focus=21987
The last message mentions a bug in "git rebase" that internally uses "git am" when replaying the changes. It was corrected later with:
http://thread.gmane.org/gmane.linux.ports.sh.devel/3833/focus=79735
Reading the discussion in the messages in this thread will help understanding the issues, after understanding why "the first line" was problematic, as discussed in the other threads.
--
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
next prev parent reply other threads:[~2008-12-28 0:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 0:32 [PATCH 1/3] pretty: factor out skip_empty_lines() René Scharfe
2008-12-27 0:39 ` [PATCH 2/3] pretty: factor out format_subject() René Scharfe
2008-12-27 0:49 ` [PATCH 3/3] pretty: support multiline subjects with format: René Scharfe
2008-12-27 23:24 ` Markus Heidelberg
2008-12-28 0:09 ` Nanako Shiraishi [this message]
2008-12-28 1:44 ` Miklos Vajna
2008-12-28 14:08 ` Markus Heidelberg
2008-12-28 0:12 ` René Scharfe
2008-12-28 14:16 ` Markus Heidelberg
2008-12-29 22:15 ` René Scharfe
2009-01-04 10:01 ` Junio C Hamano
2009-01-06 20:41 ` [PATCH 4/3] shortlog: handle multi-line subjects like log --pretty=oneline et. al. do René Scharfe
2009-01-07 21:19 ` Junio C Hamano
2008-12-28 0:13 ` [PATCH 3/3] pretty: support multiline subjects with format: Junio C Hamano
2008-12-28 14:26 ` Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081228090909.6117@nanako3.lavabit.com \
--to=nanako3@lavabit$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=markus.heidelberg@web$(echo .)de \
--cc=rene.scharfe@lsrfire$(echo .)ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox