Subject: Re: [PATCH] format-patch: avoid generation of empty patches

From: Alexander Potashev <[email-masked]>
Date: Sat, 10 Jan 2009 19:17:22 +0300

On 10:01 Sat 10 Jan     , Nathan W. Panike wrote:
> Hi:
> 
> On Sat, Jan 10, 2009 at 5:39 AM, Alexander Potashev
> <[email-masked]> wrote:
> ...
> >
> > +               if (!commit->parents && !rev.show_root_diff)
> > +                       break;
> 
> Do you really want to stop getting commits?  It seems like the break
> statement here should be a continue.

AFAIU get_revision stops revision iteration when it appears to stay at
the root commit. So, if we will replace 'break' with 'continue', the
'while' loop will finish right after that 'continue'.

However, I might be wrong... please, correct me then.

> Nathan Panike