Subject: Re: [PATCH 0/4] refactor the --color-words to make it more hackable

From: Thomas Rast <[email-masked]>
Date: Sun, 11 Jan 2009 22:53:24 +0100

Johannes Schindelin wrote:
> 
> But at least _I_ think it is easy to follow, and it actually makes the code
> more readable/hackable.  Correct me if I'm wrong.

It indeed seems a sane approach.  However, the final result segfaults
and/or prints garbage (on apparently every commit except very small
changes) when using the regex '\S+', which IMHO should give exactly
the same result as not using a regex at all.  In git.git:

  $ ./git-show --color-words='\S+' 7eb5bbdb645
  Segmentation fault
  $ ./git-show --color-words='\S+' d3240d935c4
  [...garbled output...]
  Segmentation fault

Plain --color-words is not affected.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch