Subject: Re: [PATCH 3/3] bash-completion: Added comments to remind about required arguments

From: "Shawn O. Pearce" <[email-masked]>
Date: Thu, 15 Jan 2009 07:35:43 -0800

[email-masked] wrote:
> From: Ted Pavlic <[email-masked]>
> 
>   Adds a few simple comments above commands that take arguments. These
>   comments are meant to remind developers of potential problems that can
>   occur when the script is sourced on systems with "set -u." Any
>   function which "requires" arguments really ought to be called with
>   explicit arguments given.
> 
>   Also adds a #!bash to the top of bash completions so that editing
>   software can always identify that the file is of sh type.
> 
> Signed-off-by: Ted Pavlic <[email-masked]>
> Acked-by: Shawn O. Pearce <[email-masked]>

Yup, this and also 2/3 look fine.  But again, the message, it
shouldn't be indented.

> ---
>  contrib/completion/git-completion.bash |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)

-- 
Shawn.