Subject: Re: [EGIT PATCH 01/11] Add support code to handle plugin property changes

From: "Shawn O. Pearce" <[email-masked]>
Date: Thu, 5 Feb 2009 07:53:37 -0800

Tor Arne Vestbø <[email-masked]> wrote:
> diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/Activator.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/Activator.java
> index fced643..d4a9e8e 100644
> --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/Activator.java
> +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/Activator.java
> @@ -44,9 +48,24 @@
>   * This is a plugin singleton mostly controlling logging.
>   */
>  public class Activator extends AbstractUIPlugin {
> +
> +	/**
> +	 *  The one and only instance
> +	 */
>  	private static Activator plugin;

What does this field do?  I don't see it referenced anywhere...
  
>  	/**
> +	 * Property listeners for plugin specific events
> +	 */
> +	private static List<IPropertyChangeListener> propertyChangeListeners =
> +		new ArrayList<IPropertyChangeListener>(5);

None of these list accesses are thread-safe.  Are we certain they
call will come from a single thread, e.g. the SWT event thread?
Or do we need to put synchronized protection in here?

-- 
Shawn.