Subject: Re: [EGIT PATCH 06/11] Implement basic customizable label decorations with preferences

From: Robin Rosenberg <[email-masked]>
Date: Thu, 5 Feb 2009 22:36:01 +0100

torsdag 05 februari 2009 22:00:36 skrev Tor Arne Vestbø:
> Here are two alternatives. The first one (A) uses the same icons as
> before, but adds red and green shading. The second one (B) uses the
> green plus sign for added (which is used all over the place in Eclipse
> to mean 'added'), and the gray x for removed (which is also used all
> over the place in Eclipse for that same concept).
> 
> http://img443.imageshack.us/img443/5138/egitmockupmm7.png
> 
> I favor solution B, as it uses recognizable concepts from the existing
> Eclipse UI, plus that having a red removed-icon conflicts too much with
> the conflict-icon (pun intended). There's also a very similar red icon
> in JDT that indicates that something needs fixing (a red medic kit),
> which is another reason to go with solution B.

I go with B.

Btw, shouldn't staged, added and removed also count as outgoing, i.e. ">" ?

-- robin