Subject: Re: [RFC PATCH] hooks: add some defaults to support sane workflow to pre-commit

From: Thomas Rast <[email-masked]>
Date: Sat, 21 Feb 2009 12:16:35 +0100

Heiko Voigt wrote:
> This leads me to a completely different solution to the same problem.
> How about teaching git to inherit its hooks from the parental project
> (e.g. the one it was cloned from)? That way we are not limited to
> one default behaviour but many that would match the one from the
> upstream project.
[...]
> What do you think about that?

Three words: huge security hole.

Especially on cloning, where the checkout immediately afterwards
would already run the post-checkout hook, without any chance for the
user to inspect its contents.

The usual advice is to track the hooks in the repository, e.g., under
hooks/, and instruct the users to copy them to .git/hooks/ if they
want them.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch