From: Jakub Narebski <jnareb@gmail•com>
To: David Syzdek <syzdek@gmail•com>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>,
Tim Visher <tim.visher@gmail•com>
Subject: Re: [PATCH] autoconf: Add support for --infodir
Date: Sat, 28 Feb 2009 02:57:55 +0100 [thread overview]
Message-ID: <200902280257.56932.jnareb@gmail.com> (raw)
In-Reply-To: <9a0027270902271712y57839e22w492f7ad46baf49b@mail.gmail.com>
On Sat, 28 Feb 2009, David Syzdek wrote:
> On Fri, Feb 27, 2009 at 3:33 PM, Jakub Narebski <jnareb@gmail•com> wrote:
>> On Thu, 26 Feb 2009, Jeff King wrote:
>>> On Thu, Feb 26, 2009 at 09:48:29AM -0500, Tim Visher wrote:
>>>
>>>> I'm working on getting git 1.6.2-rc2 built. I have a bin, man, info,
>>>> and html directory in my home folder that I'd like to use as the
>>>> defaults for git. I attempted to do this through
>>>>
>>>> make configure
>>>> ./configure --XXdir=/full/path/to/dir
>>>> make all man info html
>>>> make install install-man install-info install-html
[...]
>>> The configure support is notoriously incomplete (AFAIK, very few of the
>>> active developers use it regularly). Probably you need something like
>>> this (but I didn't test it):
>>>
>>> diff --git a/config.mak.in b/config.mak.in
>>> index 7cce0c1..505d5c7 100644
>>> --- a/config.mak.in
>>> +++ b/config.mak.in
>>> @@ -18,6 +18,8 @@ datarootdir = @datarootdir@
>>> template_dir = @datadir@/git-core/templates
>>>
>>> mandir=@mandir@
>>> +htmldir=@htmldir@
>>> +infodir=@infodir@
>>>
>>> srcdir = @srcdir@
>>> VPATH = @srcdir@
>>
>> Well, the infodir part works trivially, because autoconf (and
>> therefore ./configure script) has support for --infodir=DIR.
>> Below there is patch that adds that, with the commit message.
>>
>> But it is more difficult with respect to --htmldir. I am not autoconf
>> hacker, so I don't know how to add support for having --htmldir=DIR in
>> ./configure (in configure.ac). What can be done is to derive htmldir
>> in config.mak.in from other sources, for example:
>
> Autoconf add support for --htmldir in version 2.60. Here is a snippet from
> the help message from a configure script generated with 2.60:
>
> --datarootdir=DIR read-only arch.-independent data root [PREFIX/share]
>
> --docdir=DIR documentation root [DATAROOTDIR/doc/PROJECT_TARNAME]
>
> --htmldir=DIR html documentation [DOCDIR]
>
>
> The current configure.ac requires autoconf version>= 2.59, bumping the
> requirement to autoconf>= 2.60 would allow the autoconf variable $(htmldir)
> to be used. Bumping the required version of autoconf will affect users with
> older linux installations who use git to upgrade git; and may affect the
> maintainer's ability to create a "release" tarball if he has an older
> version of autoconf.
Well, I have autoconf 2.59, so I cannot test the following patch
(and I am not sure if it is welcome). And of course it needs commit
message, at least with explanation why bumping required version of
autoconf was needed.
-- >8 --
diff --git a/config.mak.in b/config.mak.in
index acff9ed..56a0147 100644
--- a/config.mak.in
+++ b/config.mak.in
@@ -19,6 +19,7 @@ template_dir = @datadir@/git-core/templates
mandir=@mandir@
infodir=@infodir@
+htmldir=@htmldir@
srcdir = @srcdir@
VPATH = @srcdir@
diff --git a/configure.ac b/configure.ac
index 082a03d..b1ab0e1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,7 +1,7 @@
# -*- Autoconf -*-
# Process this file with autoconf to produce a configure script.
-AC_PREREQ(2.59)
+AC_PREREQ(2.60)
AC_INIT([git], [@@GIT_VERSION@@], [git@vger•kernel.org])
AC_CONFIG_SRCDIR([git.c])
--
Jakub Narebski
Poland
prev parent reply other threads:[~2009-02-28 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Tim Visher <tim.visher@gmail.com>
2009-02-28 0:33 ` [PATCH] autoconf: Add support for --infodir Jakub Narebski
2009-02-28 0:45 ` Jakub Narebski
2009-02-28 1:15 ` David Syzdek
[not found] ` <9a0027270902271712y57839e22w492f7ad46baf49b@mail.gmail.com>
2009-02-28 1:57 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902280257.56932.jnareb@gmail.com \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=syzdek@gmail$(echo .)com \
--cc=tim.visher@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox