From: Markus Heidelberg <markus.heidelberg@web•de>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH] grep: don't support "grep.color"-like config options
Date: Tue, 21 Apr 2009 02:11:52 +0200 [thread overview]
Message-ID: <200904210211.52818.markus.heidelberg@web.de> (raw)
In-Reply-To: <alpine.DEB.1.00.0904210145260.10279@pacific.mpi-cbg.de>
Johannes Schindelin, 21.04.2009:
> Hi,
>
> On Tue, 21 Apr 2009, Markus Heidelberg wrote:
>
> > color.grep and color.grep.* is the official and documented way to
> > highlight grep matches. Comparable options like diff.color.* and
> > status.color.* exist for backward compatibility reasons only and are not
> > documented any more.
>
> But is it really so bad that we have to possibly break existing setups?
Given that they have never been documented since introduction of "grep
--color" in March, wouldn't it be pure luck from a users' POV, that they
even worked, after the user accidentally typed grep.color instead of
color.grep with git-config?
Should we then also introduce branch.color afterwards?
Also, colorized grep isn't yet released, people currently using
grep.color (and I guess they are very few, if any) normally are
compiling git on their own and shouldn't have problems with it
disappearing.
> The cost of keeping them is really small IMHO.
Maybe, but it's always nice to keep things simpler and cleaner.
Markus
next prev parent reply other threads:[~2009-04-21 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 22:58 [PATCH] grep: don't support "grep.color"-like config options Markus Heidelberg
2009-04-20 23:45 ` Johannes Schindelin
2009-04-21 0:11 ` Markus Heidelberg [this message]
2009-04-21 5:55 ` Junio C Hamano
2009-04-21 7:57 ` Markus Heidelberg
2009-04-21 15:45 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904210211.52818.markus.heidelberg@web.de \
--to=markus.heidelberg@web$(echo .)de \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox