Subject: Re: [PATCH JGIT] Method invokes inefficient new String(String) constructor

From: "Shawn O. Pearce" <[email-masked]>
Date: Mon, 27 Apr 2009 16:17:01 -0700

"Sohn, Matthias" <[email-masked]> wrote:
> Using the java.lang.String(String) constructor wastes memory because the
> object so constructed will be functionally
> indistinguishable from the String passed as a parameter.  Just use the
> argument String directly.

NAK.

Like the Long.valueOf() case this came up before:

http://thread.gmane.org/gmane.comp.version-control.git/113739/focus=113787
 
-- 
Shawn.