From: Eric Wong <normalperson@yhbt•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, Michael J Gruber <git@drmicha•warpmail.net>,
Mark Lodato <lodatom@gmail•com>
Subject: Re: [PATCH v3] git-svn: add --authors-prog option
Date: Thu, 21 May 2009 01:43:43 -0700 [thread overview]
Message-ID: <20090521084343.GA6401@dcvr.yhbt.net> (raw)
In-Reply-To: <1242350835-22684-1-git-send-email-lodatom@gmail.com>
Mark Lodato <lodatom@gmail•com> wrote:
> Signed-off-by: Mark Lodato <lodatom@gmail•com>
Thanks again Mark, sorry again for the late response, it's been
a long few weeks for me.
Acked-by: Eric Wong <normalperson@yhbt•net>
And pushed out to git://git.bogomips.org/git-svn along with
a few others that I had acked:
Alex Vandiver (3):
git-svn: Fix for svn paths removed > log-window-size revisions ago
git-svn: Correctly report max revision when following deleted paths
git-svn: Set svn.authorsfile if it is passed to git svn clone
Eygene Ryabinkin (1):
git-svn testsuite: use standard configuration for Subversion tools
Mark Lodato (1):
git-svn: add --authors-prog option
> ---
>
> Third attempt at the patch. I fixed a typo and reworded the documentation
> (thanks to Michael Gruber), and I fixed a small mistake in the commit message.
> Other than rebasing onto master, nothing else was changed.
A bunch of tests got broken but I squished this on top to fix them:
diff --git a/git-svn.perl b/git-svn.perl
index af80e24..a70c7d7 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -265,7 +265,9 @@ usage(0) if $_help;
version() if $_version;
usage(1) unless defined $cmd;
load_authors() if $_authors;
-$_authors_prog = "'" . File::Spec->rel2abs($_authors_prog) . "'";
+if (defined $_authors_prog) {
+ $_authors_prog = "'" . File::Spec->rel2abs($_authors_prog) . "'";
+}
unless ($cmd =~ /^(?:clone|init|multi-init|commit-diff)$/) {
Git::SVN::Migration::migration_check();
--
Eric Wong
next prev parent reply other threads:[~2009-05-21 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 1:11 [PATCH v2] git-svn: add --authors-prog option Mark Lodato
2009-05-08 7:43 ` Michael J Gruber
2009-05-09 3:48 ` Mark Lodato
2009-05-10 0:35 ` Eric Wong
2009-05-15 1:27 ` [PATCH v3] " Mark Lodato
2009-05-21 8:43 ` Eric Wong [this message]
2009-05-21 14:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090521084343.GA6401@dcvr.yhbt.net \
--to=normalperson@yhbt$(echo .)net \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=lodatom@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox