From: "Shawn O. Pearce" <spearce@spearce•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org,
Daniel Trstenjak <Daniel.Trstenjak@online•de>,
Daniel Trstenjak <Daniel.Trstenjak@science-computing•de>
Subject: Re: [PATCH] Show presense of stashed changes in bash prompt.
Date: Tue, 2 Jun 2009 08:29:15 -0700 [thread overview]
Message-ID: <20090602152915.GK30527@spearce.org> (raw)
In-Reply-To: <7vzlcqfyli.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox•com> wrote:
> Daniel Trstenjak <Daniel.Trstenjak@online•de> writes:
> > Avoid the forgetting of stashed changes by showing
> > them in the bash prompt.
> >
> > If the presense is shown is configurable by setting
> > GIT_PS1_SHOW_STASH_STATE to a nonempty value.
>
> Why am I getting this deja-vu feeling about this patch, I wonder... Is
> this a re-roll of a previously posted patch?
I don't know... I had a similar deja-vu feeling when I read it.
> Shawn?
Initial NAK, see below for the nit.
> > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> > index 98b9cbe..ed0c463 100755
> > --- a/contrib/completion/git-completion.bash
> > +++ b/contrib/completion/git-completion.bash
> > @@ -40,6 +40,10 @@
> > # with the bash.showDirtyState variable, which defaults to true
> > # once GIT_PS1_SHOWDIRTYSTATE is enabled.
> > #
> > +# You can also see if currently something is stashed, by setting
> > +# GIT_PS1_SHOW_STASH_STATE to a nonempty value. If something is stashed,
> > +# then a '$' will be shown next to the branch name.
> > +#
Can we call this GIT_PS1_SHOWSTASHSTATE to match the already present
GIT_PS1_SHOWDIRTYSTATE in at least style formatting?
The bike shed already sailed... GIT_PS1_SHOWDIRTYSTATE shipped in
1.6.3. Lets keep the same style.
Otherwise it looks fine to me, when you resend you can add my
Acked-by: Shawn O. Pearce <spearce@spearce•org>
--
Shawn.
next prev parent reply other threads:[~2009-06-02 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 11:43 [PATCH] Show presense of stashed changes in bash prompt Daniel Trstenjak
[not found] ` <7vzlcqfyli.fsf@alter.siamese.dyndns.org>
2009-06-02 15:29 ` Shawn O. Pearce [this message]
2009-06-02 18:03 ` Daniel Trstenjak
2009-06-02 18:36 ` Jakub Narebski
2009-06-02 18:04 ` Daniel Trstenjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602152915.GK30527@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=Daniel.Trstenjak@online$(echo .)de \
--cc=Daniel.Trstenjak@science-computing$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox