From: Thomas Rast <trast@student•ethz.ch>
To: Johannes Sixt <j6t@kdbg•org>
Cc: Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org, Jeff King <peff@peff•net>,
Alexander Potashev <aspotashev@gmail•com>
Subject: Re: [PATCH v2 3/3] Use die_errno() instead of die() when checking syscalls
Date: Sun, 7 Jun 2009 00:27:41 +0200 [thread overview]
Message-ID: <200906070027.44136.trast@student.ethz.ch> (raw)
In-Reply-To: <200906062302.08616.j6t@kdbg.org>
Johannes Sixt wrote:
> > @@ -2262,7 +2262,6 @@ int cmd_blame(int argc, const char **argv, const char
> > *prefix)
> >
> > if (revs_file && read_ancestry(revs_file))
> > die_errno("reading graft file '%s' failed", revs_file);
> > -
> > if (cmd_is_annotate) {
> > output_option |= OUTPUT_ANNOTATE_COMPAT;
> > blame_date_mode = DATE_ISO8601;
>
> Unrelated and not an improvement.
I used an Emacs macro to turn the die(..., strerror(errno)) [that I
had from v1] into die_errno, and obviously something went terribly
wrong _and_ I missed it. Sorry :-(
I'll make a new version tomorrow.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2009-06-06 22:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 21:34 [PATCH] add strerror(errno) to die() calls where applicable Thomas Rast
2009-06-03 1:55 ` Jeff King
[not found] ` <2325a7950906031855t1977448lbb1c8aa671c72f3d@mail.gmail.com>
2009-06-04 1:58 ` Alexander Potashev
2009-06-04 20:32 ` Jeff King
2009-06-04 2:05 ` [PATCH] diesys calls die and also reports strerror(errno) Alexander Potashev
2009-06-04 20:50 ` Jeff King
2009-06-04 21:13 ` Junio C Hamano
2009-06-05 6:25 ` Johannes Sixt
2009-06-05 7:12 ` Junio C Hamano
2009-06-06 22:09 ` Jeff King
2009-06-06 13:09 ` [PATCH] add strerror(errno) to die() calls where applicable Thomas Rast
2009-06-06 14:44 ` [PATCH v2 0/3] Thomas Rast <trast@student•ethz.ch> Thomas Rast
2009-06-06 14:44 ` [PATCH v2 1/3] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-06 20:36 ` Johannes Sixt
2009-06-06 20:56 ` Thomas Rast
2009-06-06 21:17 ` Johannes Sixt
2009-06-06 22:47 ` Jeff King
2009-06-06 22:13 ` Jeff King
2009-06-07 11:12 ` Alexander Potashev
2009-06-07 16:57 ` Junio C Hamano
2009-06-08 12:36 ` Jeff King
2009-06-08 15:35 ` Alexander Potashev
2009-06-08 22:04 ` Jeff King
2009-06-06 14:44 ` [PATCH v2 2/3] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-06 20:31 ` Johannes Sixt
2009-06-06 14:44 ` [PATCH v2 3/3] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-06 21:02 ` Johannes Sixt
2009-06-06 22:27 ` Thomas Rast [this message]
2009-06-08 21:02 ` [PATCH v3 0/3] die_errno() Thomas Rast
2009-06-08 21:02 ` [PATCH v3 1/3] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-08 22:07 ` Jeff King
2009-06-09 8:22 ` Thomas Rast
2009-06-09 8:53 ` Jeff King
2009-06-09 9:29 ` Andreas Ericsson
2009-06-08 21:02 ` [PATCH v3 2/3] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-08 21:02 ` [PATCH v3 3/3] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-27 15:58 ` [PATCH v4 0/4] die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 1/4] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 2/4] die_errno(): double % in strerror() output just in case Thomas Rast
2009-06-27 15:58 ` [PATCH v4 3/4] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 4/4] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-27 18:38 ` [PATCH v4 0/4] die_errno() Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906070027.44136.trast@student.ethz.ch \
--to=trast@student$(echo .)ethz.ch \
--cc=aspotashev@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j6t@kdbg$(echo .)org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox