public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Markus Heidelberg <markus.heidelberg@web•de>
To: Joe Perches <joe@perches•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/2] git-send-email.perl: Don't add header "In-Reply-To:" when --no-chain-reply-to set
Date: Wed, 1 Jul 2009 18:59:59 +0200	[thread overview]
Message-ID: <200907011900.00131.markus.heidelberg@web.de> (raw)
In-Reply-To: <1246429653.6259.111.camel@Joe-Laptop.home>

Joe Perches, 01.07.2009:
> On Wed, 2009-07-01 at 08:18 +0200, Markus Heidelberg wrote:
> > Joe Perches, 01.07.2009:
> > > using
> > >   git format-patch --thread=shallow -o <foo>
> > > and
> > >   git send-email --no-thread --no-chain-reply-to <foo>
> > 
> > I guess you meant --thread here.
> 
> Actually, I did mean --no-thread.

But --no-thread doesn't duplicate, --thread does.

According to the last line of your patch, you are using an old version
1.6.3.1. After this version two threading bugs were fixed, so you may
encounter a wrong behaviour with your old version.

> If format-patch does the threading, send-email shouldn't.

If the user wants format-patch to do the threading, he shouldn't want
send-email to do it as well.

Markus

  reply	other threads:[~2009-07-01 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 23:40 [PATCH 0/2] format-patch and send-email Joe Perches
2009-06-30 23:40 ` [PATCH 1/2] git-send-email.perl: Don't add header "In-Reply-To:" when --no-chain-reply-to set Joe Perches
2009-07-01  6:18   ` Markus Heidelberg
2009-07-01  6:27     ` Joe Perches
2009-07-01 16:59       ` Markus Heidelberg [this message]
2009-07-01 17:25         ` Joe Perches
2009-06-30 23:40 ` [PATCH 2/2] format-patch: Add --cover-letter-wrap Joe Perches
2009-07-02  6:45   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907011900.00131.markus.heidelberg@web.de \
    --to=markus.heidelberg@web$(echo .)de \
    --cc=git@vger$(echo .)kernel.org \
    --cc=joe@perches$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox