public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Eric Wong <normalperson@yhbt•net>
To: Ka-Hing Cheung <kcheung@riverbed•com>
Cc: git@vger•kernel.org
Subject: Re: git svn clone -r HEAD
Date: Sun, 19 Jul 2009 22:55:14 -0700	[thread overview]
Message-ID: <20090720055514.GA3229@dcvr.yhbt.net> (raw)
In-Reply-To: <1247771532.7382.115.camel@localhost>

Ka-Hing Cheung <kcheung@riverbed•com> wrote:
> Hi (not subscribed),
> 
> git-svn uses $ra->get_latest_revnum to find out the latest revision, but
> that can be problematic, because get_latest_revnum returns the latest
> revnum in the entire repository, not restricted by whatever URL you used
> to construct $ra. So if you do git svn clone -r HEAD
> svn://blah/blah/trunk, it won't work if the latest checkin is in one of
> the branches (it will try to fetch a rev that doesn't exist in trunk,
> making the clone useless).
> 
> This change seems to work, sorry it's not a proper diff:
> @sub fetch_all {
> -       my $head = $ra->get_latest_revnum;
> +       my $head = undef;
> +       $ra->get_log("", -1, 0, 1, 0, 1, sub { $head = $_[1] });

Thanks Ka-Hing,

There's an unrelated issue with $ra->get_log being broken with http(s)
URLs that need escaping, so t9118 is failing on me when SVN_HTTPD_PORT
is set (I just found another fix that broke that test, too).  I'll push
out this fix when I can get t9118 fixed with HTTP.

-- 
Eric Wong

next prev parent reply	other threads:[~2009-07-20  5:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 19:12 git svn clone -r HEAD Ka-Hing Cheung
2009-07-20  5:55 ` Eric Wong [this message]
2009-07-23  6:43   ` [PATCH] git svn: fix shallow clone when upstream revision is too new Eric Wong
2009-07-23  6:47     ` Eric Wong
2009-07-23  6:56       ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090720055514.GA3229@dcvr.yhbt.net \
    --to=normalperson@yhbt$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=kcheung@riverbed$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox