Subject: Re: [JGIT PATCH v2] FindBugs: don't use new String(String) in RefDatabase

From: Robin Rosenberg <[email-masked]>
Date: Tue, 21 Jul 2009 16:50:36 +0200

måndag 13 juli 2009 16:53:08 skrev "Shawn O. Pearce" <[email-masked]>:
>  Yann Simon <[email-masked]> wrote:
>  > This method is quite clear.
>  > One line javadoc would make it even clearer... :p (and maybe make Robin happy)
>  
>  Javadoc is overrated.  Private utility methods like this that are one
>  line long don't need documentation.  The rationale for why this line
>  does what it does is something that `git blame` can answer better.

Sorry Yann, I'm with Shawn here. A comment wouldn't add anything here since
the method is pretty simple. Besides javadocs are for API's so an inline comment
would be better, but I don't think it is necessary.

Shawn, any references for the ability of JIT's abilities to stack allocate in this context? For
me learning, will commit anyway.

-- robina