Subject: Re: [PATCH] Work around performance bug in subprocess.Popen.communicate()

From: Karl Wiberg <[email-masked]>
Date: Fri, 14 Aug 2009 10:12:20 +0200

On 2009-08-14 09:26:06 +0200, Erik Sandberg wrote:

> Wouldn't it be better to only use the write() workaround when
> sys.version indicates that the Python bug may be present, and use
> communicate() properly otherwise?

In my opinion: no. The workaround has no negative effect (since we
know that git is well-behaved). Making it conditional would only make
the code more complex, without gaining us anything.

-- 
Karl Wiberg, Virtutech