From: Jakub Narebski <jnareb@gmail•com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH] gitweb: pull ref markes pull out of subject <a> tag
Date: Sun, 23 Aug 2009 22:13:47 +0200 [thread overview]
Message-ID: <200908232213.48786.jnareb@gmail.com> (raw)
In-Reply-To: <1251016089-10548-1-git-send-email-giuseppe.bilotta@gmail.com>
On Sun, 23 Aug 2009, Giuseppe Bilotta wrote:
> Since 4afbaefffa9095fe1391b4b61289a7dc954e9f7b ref markers that
> accompain the subject in views such as shortlog and history point to
> something different from the subject itself. Therefore, they should not
> be included in the same <a> tag.
>
> Benefits of the change are:
> * better compliance to the XHTML standards, that forbid links within
> links even though the restriction cannot be imposed via DTD; this also
> benefits visualization in some older browsers;
Yes, some older browsers (like Mozilla 1.7.12, Gecko/20050923) did
_enforce_ that requirement when served document with XHTML DOCTYPE,
and application/xml+xhtml Content-Type, by moving inner link (A element)
just outside (just after) outer, containing <a> element.
For format_subject_html which you are fixing, and which is used by
'shortlog', 'history' and 'tags' views this didn't cause much changes
in layout. But the way gitweb uses git_print_header_div in views such
as 'tree', 'blob' etc., where the outer (containing) link is made into
*block* element[1] by the way of CSS (display: block) makes layout
(visualisation) very screwed up in older browser. But I don't expect
you to fix that.
[1] Originally so the area to click is larger.
> * when hovering the subject, only the subject itself is underlined; when
> hovering the ref markers, only the text in the hovered ref marker is
> underlined; previously, hovering any written part of the subject
> column led to complete underlying of everything at the same time,
> with unpleasing effects.
Signoff?
Acked-by: Jakub Narebski <jnareb@gmail•com>
> ---
> gitweb/gitweb.perl | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> The next step would be to find a way to layout decently the case when
> some shortlog entries have a _humongous_ amount of ref markers. See
> for example http://git.oblomov.eu/acecad/shortlog
>
> I honestly doubt these cases happen in normal git repositories, but it
> might still be worth taking them into consideration. Possibilities
> include hard-limiting the title column maximum width (in browsers for
> which the corresponding attributes and rules work), manual insertion of
> hard line breaks <br/> every n-th ref marker, or something more dynamic
> such as hiding most of the ref markers when they are more than, say, 5,
> and showing them on hover.
>
> Suggestions? Comments?
Perhaps limiting to heads and tags if there are too many refs?
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ce6e8f6..bb9648b 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1524,10 +1524,10 @@ sub format_subject_html {
> $long =~ s/[[:cntrl:]]/?/g;
> return $cgi->a({-href => $href, -class => "list subject",
> -title => to_utf8($long)},
> - esc_html($short) . $extra);
> + esc_html($short)) . $extra;
> } else {
> return $cgi->a({-href => $href, -class => "list subject"},
> - esc_html($long) . $extra);
> + esc_html($long)) . $extra;
> }
> }
>
> --
> 1.6.3.rc1.192.gdbfcb
>
>
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-08-23 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-23 8:28 [PATCH] gitweb: pull ref markes pull out of subject <a> tag Giuseppe Bilotta
2009-08-23 20:13 ` Jakub Narebski [this message]
2009-08-23 20:43 ` Giuseppe Bilotta
2009-08-23 22:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908232213.48786.jnareb@gmail.com \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=giuseppe.bilotta@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox