From: "Shawn O. Pearce" <spearce@spearce•org>
To: "Sohn, Matthias" <matthias.sohn@sap•com>
Cc: Robin Rosenberg <robin.rosenberg@dewire•com>,
Avery Pennarun <apenwarr@gmail•com>,
"git@vger•kernel.org" <git@vger•kernel.org>
Subject: Re: [PATCH JGIT] Circular references shouldn't be created
Date: Fri, 18 Sep 2009 14:20:17 -0700 [thread overview]
Message-ID: <20090918212017.GI14660@spearce.org> (raw)
In-Reply-To: <C89280B882467443A695734861B942B28759DEAA@DEWDFECCR09.wdf.sap.corp>
"Sohn, Matthias" <matthias.sohn@sap•com> wrote:
> Robin Rosenberg <robin.rosenberg@dewire•com> wrote on Freitag, 18. September 2009 00:52
> > I think we should do this in the UI by not allowing the user to make a
> > choice that would result in a loop and fixing the way the UI resolves
> > choices. When creating a new branch we should analyze the selected
> > ref and dereference it if it is a symbolic name like HEAD or if it is a
> > tag,
> > and perhaps show it like "HEAD (refs/heads/master)" in the the dialog.
> >
> > Using unresolvable refs as the base for a new branch should be
> > disallowed.
>
> If we would do it in the EGit UI how about catching such cases
> in other applications using JGit ?
I agree with Matthias here, other applications using JGit will
also want to be able to detect a ref loop at ref creation time,
and also at ref reading time. We should put the test function into
JGit and allow the UI to call that test function to determine if
creating that symref right now would create a loop. EGit UI can
then use that function to qualify the user's selection, and prevent
the user from making a choice which would create a loop.
--
Shawn.
prev parent reply other threads:[~2009-09-18 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 19:23 [PATCH JGIT] Circular references shouldn't be created Sohn, Matthias
2009-09-17 21:40 ` Avery Pennarun
2009-09-17 22:51 ` Robin Rosenberg
2009-09-18 6:37 ` Sohn, Matthias
2009-09-18 21:20 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090918212017.GI14660@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=apenwarr@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=matthias.sohn@sap$(echo .)com \
--cc=robin.rosenberg@dewire$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox