public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce•org>
To: Nicolas Pitre <nico@fluxnic•net>
Cc: Jason Merrill <jason@redhat•com>,
	Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
	git@vger•kernel.org, Hin-Tak Leung <hintak.leung@gmail•com>
Subject: Re: git clone sending unneeded objects
Date: Sat, 26 Sep 2009 19:04:10 -0700	[thread overview]
Message-ID: <20090927020409.GK14660@spearce.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0909262059520.4997@xanadu.home>

Nicolas Pitre <nico@fluxnic•net> wrote:
> And even if the broken clone (before my patch) did pull everything from 
> gcc.git, in the cloned repository those 410610 extra objects are 
> considered as garbage because nothing actually reference them.  So even 
> if you decide to fetch the extra branches that the initial clone didn't 
> pick up, or if you do reference that repository with "garbage" objects 
> for another clone to which you want to add those extra branches, git has 
> no way to know that it already had access to those objects locally and 
> "ungarbage" them as they aren't referenced.  Result is a useless fetch 
> of 410610 objects that you already have, but that you weren't supposed 
> to have in the first place.

Just to clarify a minor nit:

Actually, if those refs have not changed, quickfetch should kick in
and realize that all 410610 objects are reachable locally without
errors, permitting the client to avoid the object transfer.

However, if *ANY* of those refs were to change to something you
don't actually have, quickfetch would fail, and we would need to
fetch all 410610 objects.

-- 
Shawn.

  reply	other threads:[~2009-09-27  2:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-08  1:11 git gc expanding packed data? Andreas Schwab
2009-08-08 13:05 ` Hin-Tak Leung
2009-08-08 13:25   ` Andreas Schwab
2009-08-09  2:56 ` Nicolas Pitre
2009-08-09  7:43   ` Andreas Schwab
2009-09-25 18:05     ` git clone sending unneeded objects (was : git gc expanding packed data?) Jason Merrill
2009-09-25 19:34       ` git clone sending unneeded objects Matthieu Moy
2009-09-25 19:43         ` Jason Merrill
2009-09-25 19:53         ` Nicolas Pitre
2009-09-25 20:20           ` Jason Merrill
2009-09-25 20:47             ` Nicolas Pitre
2009-09-25 23:17               ` Jason Merrill
2009-09-26  0:49                 ` Nicolas Pitre
2009-09-26  3:54                   ` [PATCH] make 'git clone' ask the remote only for objects it cares about Nicolas Pitre
2009-09-26  7:21                     ` Andreas Schwab
2009-09-26 19:50                     ` Shawn O. Pearce
2009-09-27  0:26                       ` Nicolas Pitre
2009-09-26  4:44                 ` git clone sending unneeded objects Jason Merrill
2009-09-26 13:33                   ` Jason Merrill
2009-09-27  2:26                     ` Nicolas Pitre
2009-09-27  1:27                   ` Nicolas Pitre
2009-09-27  2:04                     ` Shawn O. Pearce [this message]
2009-09-27  2:31                       ` Nicolas Pitre
2009-09-27  4:35                       ` Jason Merrill
2009-09-28  4:18                         ` Nicolas Pitre
2009-09-26  0:43             ` Hin-Tak Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090927020409.GK14660@spearce.org \
    --to=spearce@spearce$(echo .)org \
    --cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=hintak.leung@gmail$(echo .)com \
    --cc=jason@redhat$(echo .)com \
    --cc=nico@fluxnic$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox