From: "Shawn O. Pearce" <spearce@spearce•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: Jonathan Nieder <jrnieder@gmail•com>,
Jens Lehmann <Jens.Lehmann@web•de>,
git@vger•kernel.org
Subject: Re: [PATCH/RFC 3/4] git check-ref-format --print
Date: Mon, 12 Oct 2009 16:26:54 -0700 [thread overview]
Message-ID: <20091012232653.GQ9261@spearce.org> (raw)
In-Reply-To: <7veip8e302.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox•com> wrote:
> I understand that you prefer the latter between "there is no tool; the
> caller is responsibile to make sure it feeds us canonical representation"
> and "there is a tool that makes a slightly malformed string into canonical
> form for the callers to use before calling us." And that would be my
> preference between these two as well.
...
> But now I have spelled this out, I do not see much upside for rejecting,
> and more importantly, I think it would be an independent issue. We can
> reject or just keep normalizing silently, and a tool to show the
> normalized name would be useful and necessary regardless of that.
I agree with the last paragraph here, we shouldn't reject, but
instead keep the current state but encourage tools to use the new
canonical print tool to clean up a name if they want to hang onto the
string the user entered and it needs to exactly match for-each-ref
sort of output.
--
Shawn.
next prev parent reply other threads:[~2009-10-12 23:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 17:49 [PATCH] disallow refs containing successive slashes Jens Lehmann
2009-10-10 21:50 ` Junio C Hamano
2009-10-11 10:42 ` Jens Lehmann
2009-10-11 18:52 ` Junio C Hamano
2009-10-12 0:31 ` Jonathan Nieder
2009-10-12 2:47 ` Nanako Shiraishi
2009-10-12 5:25 ` [PATCH/RFC 0/4] plumbing to help fix git-gui Jonathan Nieder
2009-10-12 5:27 ` [PATCH 1/4] Add tests for git check-ref-format Jonathan Nieder
2009-10-12 5:28 ` [PATCH 2/4] Documentation: describe check-ref-format --branch Jonathan Nieder
2009-10-12 5:31 ` [PATCH/RFC 3/4] git check-ref-format --print Jonathan Nieder
2009-10-12 14:39 ` Shawn O. Pearce
2009-10-12 21:06 ` Junio C Hamano
2009-10-12 23:26 ` Shawn O. Pearce [this message]
2009-10-12 23:36 ` Junio C Hamano
2009-10-13 4:49 ` Jonathan Nieder
2009-10-12 5:33 ` [PATCH/RFC 4/4] check-ref-format: simplify --print implementation Jonathan Nieder
2009-10-12 5:45 ` [PATCH/RFC 0/4] plumbing to help fix git-gui Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012232653.GQ9261@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox