From: Nanako Shiraishi <nanako3@lavabit•com>
To: Jakub Narebski <jnareb@gmail•com>
Cc: Stephen Boyd <bebarino@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] gitweb.js: Harden setting blamed commit info in incremental blame
Date: Wed, 25 Nov 2009 10:01:04 +0900 [thread overview]
Message-ID: <20091125100104.6117@nanako3.lavabit.com> (raw)
In-Reply-To: <200911250145.16472.jnareb@gmail.com>
Quoting Jakub Narebski <jnareb@gmail•com>
> On Sat, 21 Nov 2009, Jakub Narebski wrote:
>
> Below the same patch is in the form of a proper commit; although the title
> (subject) of this commit could be better...
Does this replace the first of the previous two-patch series? Is Stephen's second patch still needed (with his fix)?
Quoting Stephen Boyd <bebarino@gmail•com>
> Jakub Narebski wrote:
>> I have tested gitweb with both of your patches applied, serving gitweb
>> as CGI script using Apache 2.0.54 on Linux, and viewing from separate
>> computer on MS Windows XP, with the following results:
>>
>> * For the following browsers blame_incremental view on gitweb/gitweb.perl
>> file produces correct output, but for progress info which instead of
>> ( 1%) -> ( 29%) -> (100%) looks more like ( 1%) -> (29%) -> (100%)
>
> This is due to an off-by-one error in the while loop. This should fix
> it. I'll probably squash this into patch 2 and resend.
>
> --->8----
>
> diff --git a/gitweb/gitweb.js b/gitweb/gitweb.js
> index 30597dd..9214497 100644
> --- a/gitweb/gitweb.js
> +++ b/gitweb/gitweb.js
> @@ -43,7 +43,7 @@ function padLeftStr(input, width, str) {
> var prefix = '';
>
> width -= input.toString().length;
> - while (width > 1) {
> + while (width > 0) {
> prefix += str;
> width--;
> }
--
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
next prev parent reply other threads:[~2009-11-25 1:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 19:44 [PATCH 0/2] jn/gitweb-blame fixes Stephen Boyd
2009-11-19 19:44 ` [PATCH 1/2] gitweb.js: fix null object exception in initials calculation Stephen Boyd
2009-11-19 21:40 ` Jakub Narebski
2009-11-19 22:48 ` Stephen Boyd
2009-11-19 19:44 ` [PATCH 2/2] gitweb.js: use unicode encoding for nbsp instead of html entity Stephen Boyd
2009-11-19 23:00 ` Jakub Narebski
2009-11-20 1:00 ` Stephen Boyd
2009-11-25 3:51 ` [PATCHv2 2/2] gitweb.js: fix padLeftStr() and its usage Stephen Boyd
2009-11-19 23:05 ` [PATCH 0/2] jn/gitweb-blame fixes Jakub Narebski
2009-11-20 1:00 ` Stephen Boyd
2009-11-20 4:05 ` Stephen Boyd
2009-11-21 0:32 ` Jakub Narebski
2009-11-21 14:56 ` Jakub Narebski
2009-11-25 0:45 ` [PATCH] gitweb.js: Harden setting blamed commit info in incremental blame Jakub Narebski
2009-11-25 1:01 ` Nanako Shiraishi [this message]
2009-11-25 1:13 ` Jakub Narebski
2009-11-25 4:01 ` Stephen Boyd
2009-11-25 14:36 ` Jakub Narebski
2009-11-25 20:55 ` Jakub Narebski
2009-11-25 21:39 ` Junio C Hamano
2009-11-25 23:28 ` Jakub Narebski
2009-11-26 0:34 ` Junio C Hamano
2009-11-26 0:59 ` Jakub Narebski
2009-11-26 20:12 ` [RFC/PATCH] gitweb: Make linking to actions requiring JavaScript a feature Jakub Narebski
2009-11-26 20:34 ` Junio C Hamano
2009-11-26 21:24 ` Jakub Narebski
2009-11-27 2:39 ` Junio C Hamano
2009-11-27 15:41 ` Jakub Narebski
2009-11-27 18:29 ` Junio C Hamano
2009-12-01 1:18 ` Junio C Hamano
2009-12-01 16:51 ` Jakub Narebski
2009-12-01 16:52 ` [PATCH 1/2] " Jakub Narebski
2009-12-01 16:54 ` [PATCH 2/2] gitweb: Add link to other blame implementation in blame views Jakub Narebski
2009-12-07 1:04 ` [PATCH] gitweb.js: Harden setting blamed commit info in incremental blame Stephen Boyd
2009-12-07 1:19 ` Stephen Boyd
2009-12-08 16:29 ` PATCH/RFC] gitweb.js: Workaround for IE8 bug Jakub Narebski
2009-12-08 21:56 ` Stephen Boyd
2009-12-08 22:24 ` Jakub Narebski
2009-12-08 22:32 ` Jakub Narebski
2009-12-09 0:08 ` Stephen Boyd
2009-11-23 4:52 ` [PATCH 0/2] jn/gitweb-blame fixes Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125100104.6117@nanako3.lavabit.com \
--to=nanako3@lavabit$(echo .)com \
--cc=bebarino@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox