public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Alex Chiang <achiang@hp•com>
To: Karl Wiberg <kha@treskal•com>
Cc: catalin.marinas@gmail•com, git <git@vger•kernel.org>
Subject: Re: [StGit PATCH v2 3/6] stg mail: make __send_message do more
Date: Thu, 3 Dec 2009 12:30:19 -0700	[thread overview]
Message-ID: <20091203193018.GF23258@ldl.fc.hp.com> (raw)
In-Reply-To: <b8197bcb0912012303i3bd1061fhdb391de096996a27@mail.gmail.com>

* Karl Wiberg <kha@treskal•com>:
> Just pointing out a couple of Python tricks you might've wanted to
> use. No need to update the patch, though.
> 
> On Wed, Dec 2, 2009 at 1:46 AM, Alex Chiang <achiang@hp•com> wrote:
> 
> > +        (patch_nr, total_nr) = (args[1], args[2])
> 
> Can be written as
> 
>   (patch_nr, total_nr) = args[1:3]

Thanks, I did it this way.

> or, if args[2] is the last element of the list (which it isn't in this
> case?),
> 
>   (patch_nr, total_nr) = args[1:]

No, ref_id is the last arg, so that won't work.

> > +    for (p, n) in zip(patches, range(1, total_nr + 1)):
> > +        msg_id = __send_message('patch', tmpl, options, p, n, total_nr, ref_id)
> 
> Can be written as
> 
>   for (n, p) in enumerate(patches):
> 
> if you use n + 1 instead of n in the loop body.

That is a little cleaner, but I decided to keep it as zip(). Why?
Because using n + 1 in the loop body will push that line past 80
columns. ;)

It's also the original code (albeit with a simple variable
rename).

I know this isn't the kernel, and that there are plenty of other
lines that are 80+ characters, but if you can keep it short, why
not?

Thanks,
/ac

next prev parent reply	other threads:[~2009-12-03 19:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02  0:46 [StGit PATCH v2 0/6] add support for git send-email Alex Chiang
2009-12-02  0:46 ` [StGit PATCH v2 1/6] stg mail: Refactor __send_message and friends Alex Chiang
2009-12-02  6:53   ` Karl Wiberg
2009-12-03 19:27     ` Alex Chiang
2009-12-03 20:46     ` [StGit PATCH v3 " Alex Chiang
2009-12-02  0:46 ` [StGit PATCH v2 2/6] stg mail: reorder __build_[message|cover] parameters Alex Chiang
2009-12-02  0:46 ` [StGit PATCH v2 3/6] stg mail: make __send_message do more Alex Chiang
2009-12-02  7:03   ` Karl Wiberg
2009-12-03 19:30     ` Alex Chiang [this message]
2009-12-04  7:00       ` Karl Wiberg
2009-12-02  0:46 ` [StGit PATCH v2 4/6] stg mail: factor out __update_header Alex Chiang
2009-12-02  0:46 ` [StGit PATCH v2 5/6] stg mail: add basic support for git send-email Alex Chiang
2009-12-02  0:46 ` [StGit PATCH v2 6/6] stg mail: don't parse To/Cc/Bcc in --git mode Alex Chiang
2009-12-02  6:46 ` [StGit PATCH v2 0/6] add support for git send-email Karl Wiberg
2009-12-03 19:27   ` Alex Chiang
2009-12-02  7:08 ` Karl Wiberg
2009-12-02 22:35 ` Catalin Marinas
2009-12-06 22:16 ` Catalin Marinas
2009-12-07  7:09   ` Karl Wiberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091203193018.GF23258@ldl.fc.hp.com \
    --to=achiang@hp$(echo .)com \
    --cc=catalin.marinas@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=kha@treskal$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox