From: Ilari Liusvaara <ilari.liusvaara@elisanet•fi>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: [REROLL PATCH 6/8] Support remote helpers implementing smart transports
Date: Wed, 9 Dec 2009 17:16:30 +0200 [thread overview]
Message-ID: <20091209151630.GC15673@Knoppix> (raw)
In-Reply-To: <7vein5594u.fsf@alter.siamese.dyndns.org>
On Tue, Dec 08, 2009 at 03:38:41PM -0800, Junio C Hamano wrote:
> Ilari Liusvaara <ilari.liusvaara@elisanet•fi> writes:
> >
> > +'connect' <service>::
> > + Connects to given service. Stdin and stdout of helper are
>
> A minor point, but in prose, unless it explains how to use "stdin" and
> "stdout" as a variable, keyword, etc. in code, I'd prefer to see these
> spelled out, like so:
>
> The standard input and output of helpers are connected to ...
Changed.
> > -static int recvline(struct helper_data *helper, struct strbuf *buffer)
> > +static int _recvline(FILE *helper, struct strbuf *buffer)
> > {
>
> recvline_fh() vs revline() might be better as most of the interaction in
> this layer are done on helper_data, which makes the name recvline() pair
> nicely with sendline that also takes helper_data; and the oddball one that
> is _not_ an implementation detail (i.e. you have calls outside recvline()
> implementation that call _recvline()) hints that it takes filehandle
> instead.
- _recvline -> recvline_fh
- _process_connect -> process_connect_service
-Ilari
next prev parent reply other threads:[~2009-12-09 15:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 13:16 [REROLL PATCH 0/8] Remote helpers smart transport extensions Ilari Liusvaara
2009-12-08 13:16 ` [REROLL PATCH 1/8] Add remote helper debug mode Ilari Liusvaara
2009-12-08 23:34 ` Junio C Hamano
2009-12-08 13:16 ` [REROLL PATCH 2/8] Support mandatory capabilities Ilari Liusvaara
2009-12-08 23:34 ` Junio C Hamano
2009-12-09 15:12 ` Ilari Liusvaara
2009-12-08 13:16 ` [REROLL PATCH 3/8] Pass unknown protocols to external protocol handlers Ilari Liusvaara
2009-12-08 23:35 ` Junio C Hamano
2009-12-09 8:55 ` Bert Wesarg
2009-12-09 15:15 ` Ilari Liusvaara
2009-12-08 13:16 ` [REROLL PATCH 4/8] Refactor git transport options parsing Ilari Liusvaara
2009-12-08 13:16 ` [REROLL PATCH 5/8] Support taking over transports Ilari Liusvaara
2009-12-08 23:37 ` Junio C Hamano
2009-12-09 15:17 ` Ilari Liusvaara
2009-12-09 21:08 ` Junio C Hamano
2009-12-09 21:42 ` Ilari Liusvaara
2009-12-08 13:16 ` [REROLL PATCH 6/8] Support remote helpers implementing smart transports Ilari Liusvaara
2009-12-08 23:38 ` Junio C Hamano
2009-12-09 15:16 ` Ilari Liusvaara [this message]
2009-12-08 13:16 ` [REROLL PATCH 7/8] Support remote archive from external protocol helpers Ilari Liusvaara
2009-12-08 23:39 ` Junio C Hamano
2009-12-09 15:16 ` Ilari Liusvaara
2009-12-08 13:16 ` [REROLL PATCH 8/8] Remove special casing of http, https and ftp Ilari Liusvaara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209151630.GC15673@Knoppix \
--to=ilari.liusvaara@elisanet$(echo .)fi \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox