public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Eric Wong <normalperson@yhbt•net>
To: Sam Vilain <sam@vilain•net>
Cc: Andrew Myrick <amyrick@apple•com>, git@vger•kernel.org
Subject: Re: [spf:guess] Re: [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick
Date: Wed, 6 Jan 2010 22:49:16 -0800	[thread overview]
Message-ID: <20100107064916.GA8557@dcvr.yhbt.net> (raw)
In-Reply-To: <4B4510EE.4090504@vilain.net>

Sam Vilain <sam@vilain•net> wrote:
> Eric Wong wrote:
> > Andrew Myrick <amyrick@apple•com> wrote:
> >   
> >> diff --git a/git-svn.perl b/git-svn.perl
> >
> > Hi Andrew,
> >
> > I'll again defer to Sam for Acks on these.  Test cases would be nice to
> > have, too.
> >   
> 
> They look fine to me, agreed a test case would be nice and make sure the
> features aren't lost later inadvertently.

Thanks Sam,

Shall I consider this an Ack and push Andrew's new changes
up while waiting for test cases?

-- 
Eric Wong

next prev parent reply	other threads:[~2010-01-07  6:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06 20:08 [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick Andrew Myrick
2010-01-06 20:08 ` [PATCH 2/2] git-svn: handle merge-base failures Andrew Myrick
2010-01-06 21:43 ` [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick Eric Wong
2010-01-06 22:38   ` [spf:guess] " Sam Vilain
2010-01-07  6:49     ` Eric Wong [this message]
2010-01-07  9:05       ` [spf:guess] " Sam Vilain
2010-01-06 22:52   ` Andrew Myrick
2010-01-07  0:25     ` Andrew Myrick
2010-01-07  0:25       ` [PATCH 2/2] git-svn: handle merge-base failures Andrew Myrick
2010-01-07  9:50       ` [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick Eric Wong
2010-01-21 21:55     ` [PATCH] git-svn: update svn mergeinfo test suite Andrew Myrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100107064916.GA8557@dcvr.yhbt.net \
    --to=normalperson@yhbt$(echo .)net \
    --cc=amyrick@apple$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=sam@vilain$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox