From: "Shawn O. Pearce" <spearce@spearce•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: Nicolas Pitre <nico@fluxnic•net>,
"Mike.lifeguard" <mike.lifeguard@gmail•com>,
Avery Pennarun <apenwarr@gmail•com>,
Scott Chacon <schacon@gmail•com>,
Jonathan Nieder <jrnieder@gmail•com>, git <git@vger•kernel.org>
Subject: Re: Tree with leading '0' modes in 1.7.0.3
Date: Sat, 27 Mar 2010 12:20:18 -0700 [thread overview]
Message-ID: <20100327192018.GG10910@spearce.org> (raw)
In-Reply-To: <7vvdci2vk8.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox•com> wrote:
> "Shawn O. Pearce" <spearce@spearce•org> writes:
>
> > But GitHub's approach here seems to be "Meh, its fine, don't worry
> > about it".
> >
> > Its *NOT* fine. But Avery and Junio might disagree with me. :-)
>
> Did I ever say it is _fine_? I thought I said "complain loudly".
I apologize if I misrepresented you above.
> That would at least give poor jgit users who have hit such a corrupted
> object a chance to get a controlled notice and ask for help (and get an
> insn to recover with filter-branch that appeared in this thread).
Well, there is "complain loudly but do it anyway" and "hard stop".
JGit currently has the leading '0' be a "hard stop". Because this is
the fsck code running inside of the receive-pack service, validating
what the user sent is isn't malformed. Its clearly malformed.
This only got discovered because Mike tried to take a repository
from GitHub and push it into Gerrit Code Review, where JGit's fsck
routine cannot be bypassed during receive-pack.
Are you suggesting JGit should change its behavior to be "complain
loudly but do it anyway"? I'm open to making the code change there
if that is how you think a Git implementation should behave in
this case. But I don't want to do it just to match CGit's behavior,
sometimes CGit can be wrong. :-)
--
Shawn.
next prev parent reply other threads:[~2010-03-27 19:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 21:56 Tree with leading '0' modes in 1.7.0.3 Shawn O. Pearce
2010-03-26 22:26 ` Jonathan Nieder
2010-03-26 22:29 ` Shawn O. Pearce
2010-03-26 22:40 ` Jonathan Nieder
2010-03-26 23:09 ` Junio C Hamano
2010-03-26 22:59 ` Mike.lifeguard
2010-03-26 23:05 ` Shawn O. Pearce
2010-03-26 23:22 ` Mike.lifeguard
2010-03-26 23:49 ` Jonathan Nieder
2010-03-26 23:50 ` Junio C Hamano
2010-03-26 23:56 ` Avery Pennarun
2010-03-27 0:00 ` Mike.lifeguard
2010-03-27 1:22 ` Shawn O. Pearce
2010-03-27 1:30 ` Nicolas Pitre
2010-03-27 1:34 ` Shawn O. Pearce
2010-03-27 1:56 ` Nicolas Pitre
2010-03-27 2:33 ` Avery Pennarun
2010-03-27 12:44 ` Scott Chacon
2010-03-27 14:21 ` Nicolas Pitre
2010-03-27 19:14 ` Shawn O. Pearce
2010-03-27 19:30 ` A Large Angry SCM
2010-03-27 19:32 ` Shawn O. Pearce
2010-03-27 19:39 ` A Large Angry SCM
2010-03-27 19:44 ` A Large Angry SCM
2010-03-27 19:57 ` A Large Angry SCM
2010-03-28 17:38 ` Sitaram Chamarty
2010-03-28 23:28 ` A Large Angry SCM
2010-03-27 20:13 ` A Large Angry SCM
2010-03-27 20:16 ` Junio C Hamano
2010-03-27 22:16 ` Avery Pennarun
2010-03-27 5:16 ` Junio C Hamano
2010-03-27 19:20 ` Shawn O. Pearce [this message]
2010-03-27 20:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100327192018.GG10910@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=apenwarr@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=mike.lifeguard@gmail$(echo .)com \
--cc=nico@fluxnic$(echo .)net \
--cc=schacon@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox