Subject: Re: [PATCHv5 6/6] gitweb: update INSTALL to use shorter make target

From: Jakub Narebski <[email-masked]>
Date: Thu, 1 Apr 2010 14:25:29 +0200

On Thu, 1 Apr 2010, Mark Rada wrote:

> Gitweb can be generated by the gitweb/gitweb.cgi target or the gitweb
> target. Since the gitweb target is shorter, I think it would be better
> to have new users be instructed to use it.

Good idea.
  
> -	$ make prefix=/usr gitweb/gitweb.cgi  ;# as yourself
> +	$ make prefix=/usr gitweb.cgi         ;# as yourself
>  	# cp gitweb/git* /var/www/cgi-bin/    ;# as root

But it should read

-	$ make prefix=/usr gitweb/gitweb.cgi  ;# as yourself
+	$ make prefix=/usr gitweb             ;# as yourself

The target is "gitweb", not "gitweb.cgi"
  
>  Alternatively you can use autoconf generated ./configure script to
> @@ -16,7 +15,7 @@ instead
>  
>  	$ make configure                     ;# as yourself
>  	$ ./configure --prefix=/usr          ;# as yourself
> -	$ make gitweb/gitweb.cgi             ;# as yourself
> +	$ make gitweb.cgi                    ;# as yourself

Same here.

> @@ -86,7 +84,7 @@ Build example
>  	     GITWEB_LOGO="/gitweb/git-logo.png" \
>  	     GITWEB_FAVICON="/gitweb/git-favicon.png" \
>  	     bindir=/usr/local/bin \
> -	     gitweb/gitweb.cgi
> +             gitweb.cgi

Same here.  Also spaces in place of TAB.

-- 
Jakub Narebski
Poland