Subject: Re: [PATCH v2 3/3] send-email: Add sendemail.smtpdomain

From: Jakub Narebski <[email-masked]>
Date: Fri, 9 Apr 2010 20:40:49 +0200

On Fri, 9 Apr 2010, Brian Gernhardt wrote:

> diff --git a/git-send-email.perl b/git-send-email.perl
> index f491d44..bdfe3f2 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -132,8 +132,7 @@ my $have_email_valid = eval { require Email::Valid; 1 };
>  my $have_mail_address = eval { require Mail::Address; 1 };
>  my $smtp;
>  my $auth;
> -my $mail_domain_default = "localhost.localdomain";
> -my $mail_domain;
> +my $smtp_domain_default = "localhost.localdomain";

Why this change, this renaming of variables from $mail_domain_default
and $mail_domain to $smtp_domain_default and $smtp_domain?  Why you
have removed this forward declaration of $smtp_domain/$mail_domain?
  
>  sub unique_email_list(@);
>  sub cleanup_compose_files();
> @@ -190,7 +189,7 @@ sub do_edit {
>  # Variables with corresponding config settings
>  my ($thread, $chain_reply_to, $suppress_from, $signed_off_by_cc, $cc_cmd);
>  my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption);
> -my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts);
> +my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts, $smtp_domain);
>  my ($validate, $confirm);
>  my (@suppress_cc);

Why have you moved $smtp_domain declaration (formerly $mail_domain)
here?  And why it is not described in commit message (at least "Cleanup.",
or something like this)?

-- 
Jakub Narebski
Poland