Subject: Re: [PATCH] fsck: check ident lines in commit objects

From: "Shawn O. Pearce" <[email-masked]>
Date: Sat, 24 Apr 2010 12:04:19 -0700

Jonathan Nieder <[email-masked]> wrote:
> Check that email addresses do not contain <, >, or newline so they can
> be quickly scanned without trouble.  The copy() function in ident.c
> already ensures that ordinary git commands will not write email
> addresses without this property.
> 
> Signed-off-by: Jonathan Nieder <[email-masked]>
> ---
> Thoughts?  Should some of these errors be warnings?

These should be errors.  We should never see this sort of thing
occur in a live repository.
 
> git fast-import is capable of producing commits with some of these
> problems: for example, it is fine with
> 
> 	committer C O Mitter <foo@b>ar.net> 005 -    +5

Yuck.  We probably should tighten up the parser in fast-import a
bit more.  The above is pretty insane for it to produce into the
repository.  I can't even begin to count how many ways the above
line is just wrong...  :-)

-- 
Shawn.