Subject: Re: [PATCHv4 3/3] git-instaweb: Add support for running gitweb via 'plackup'

From: Eric Wong <[email-masked]>
Date: Sat, 29 May 2010 02:32:52 +0000

Jakub Narebski <[email-masked]> wrote:
> +	open my \$access_log_fh, '>', "\$logdir/access.log"
> +		or die "Couldn't open access log '\$logdir/access.log': \$!";
> +	open my \$error_log_fh,  '>', "\$logdir/error.log"
> +		or die "Couldn't open error log '\$logdir/error.log': \$!";

I believe '>>' (append) is preferable for log files and matches the
behavior of all other servers.  Other than that everything else looks
good.  I can make that change myself + Ack + push for Junio.

-- 
Eric Wong