From: Jakub Narebski <jnareb@gmail•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: git@vger•kernel.org,
Pavan Kumar Sunkara <pavan.sss1991@gmail•com>,
Petr Baudis <pasky@ucw•cz>,
Christian Couder <chriscool@tuxfamily•org>
Subject: Re: [PATCHv2/RFC] gitweb: Prepare for splitting gitweb
Date: Wed, 14 Jul 2010 23:21:24 +0200 [thread overview]
Message-ID: <201007142321.26034.jnareb@gmail.com> (raw)
In-Reply-To: <AANLkTikDtlHwtk4j0E5vYViFVWtsV_yA5e90z-6nZb8_@mail.gmail.com>
On Wed, 14 Jul 2010, Ævar Arnfjörð Bjarmason wrote:
> On Wed, Jul 14, 2010 at 09:24, Jakub Narebski <jnareb@gmail•com> wrote:
>> On Wed, 14 Jul 2010, Ævar Arnfjörð Bjarmason wrote:
>>> On Tue, Jul 13, 2010 at 22:24, Jakub Narebski <jnareb@gmail•com> wrote:
>>>
>>>> I wrote simple script that tests result of __DIR__ and $FindBin::Bin.
>>>> For cgi-bin / mod_cgi it was:
>>>>
>>>> __DIR__ = /var/www/cgi-bin/gitweb (symlink to /home/local/gitweb)
>>>> $FindBin::Bin = /home/local/gitweb
>>>>
>>>> For mod_perl (ModPerl::Registry handler) it was
>>>>
>>>> __DIR__ = /var/www/perl/gitweb (symlink to /home/local/gitweb)
>>>> $FindBin::Bin = /
>>>>
>>>> As you can see it's useless. I have't checked the FastCGI case...
>>>
>>> Thanks for spending time researching what was an offhand ignorant "hey
>>> wasn't .." comment. Also, sorry :)
>>
>> Nothing to it. I wanted to check if there really is a problem with
>> FindBin on mod_perl, as I was not sure with description in "Known Issues"
>> section in FindBin manpage.
>>
>> Note that using 'FindBin->again();' after 'use FindBin;' fixes this
>> issue. So perhaps it would be beter to use FindBin than borrow code
>> for __DIR__ from Dir::Self.
>
> That should work, though note that FindBin->again requires at least
> perl 5.8.3. This should work on older versions (if Gitweb cares):
>
> if ($] <= 5.008003) {
> delete $INC{'FindBin.pm'};
> require FindBin;
> } else {
> FindBin->again;
> }
>
> See https://rt.cpan.org/Public/Bug/Display.html?id=57988 and
> http://search.cpan.org/diff?from=Module-Install-0.98&to=Module-Install-0.99
> for reference.
Thanks for research.
I don't think gitweb cares, as it requires Perl with sane Unicode support,
which means at least Perl 5.8.0 (for Encode module), but I think it really
means at least 5.8.3
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-07-14 21:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 9:57 [PATCHv2/RFC] gitweb: Prepare for splitting gitweb Jakub Narebski
2010-07-07 10:30 ` Ævar Arnfjörð Bjarmason
2010-07-07 20:05 ` Jakub Narebski
2010-07-08 7:01 ` Jakub Narebski
2010-07-13 22:24 ` Jakub Narebski
2010-07-13 22:30 ` Ævar Arnfjörð Bjarmason
2010-07-14 9:24 ` Jakub Narebski
2010-07-14 10:05 ` Ævar Arnfjörð Bjarmason
2010-07-14 21:21 ` Jakub Narebski [this message]
2010-07-07 16:25 ` Junio C Hamano
2010-07-07 20:20 ` Jakub Narebski
2010-07-08 0:30 ` Junio C Hamano
2010-07-08 6:59 ` Jakub Narebski
2010-07-08 7:20 ` [PATCHv3/RFC] " Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007142321.26034.jnareb@gmail.com \
--to=jnareb@gmail$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=pasky@ucw$(echo .)cz \
--cc=pavan.sss1991@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox