From: "Dmitry V. Levin" <ldv@altlinux•org>
To: git@vger•kernel.org
Subject: Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point
Date: Fri, 30 Jul 2010 12:44:28 +0400 [thread overview]
Message-ID: <20100730084428.GA9577@wo.int.altlinux.org> (raw)
In-Reply-To: <201007300136.13501.trast@student.ethz.ch> <AANLkTi=Qf1OUmjkpL-6e8gT8MU9G=m37sxrdAoyj5=R0@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
On Thu, Jul 29, 2010 at 11:07:20PM +0000, Ævar Arnfjörð Bjarmason wrote:
> On Thu, Jul 29, 2010 at 22:01, Dmitry V. Levin wrote:
[...]
> > +test_expect_success setup '
> > + echo a > a &&
> > + git add a &&
> > + test_tick &&
> > + git commit -m first &&
> > + echo b > b &&
> > + git add b &&
> > + test_tick &&
> > + git commit -m second
> > +'
>
> This should use test_commit (see t/README), but...
The peculiarity of this bug makes it impossible, because test_commit()
also creates a tag which spoils test conditions.
> > +test_expect_success checkout '
> > + git checkout -b new_branch :/first
> > +'
> > +
> > +test_done
>
> ...it looks like this can just be added to the end of
> t2018-checkout-branch.sh instead of creating a new test. Creating a
> new file just for a single test for such a simple feature is a bit of
> an overkill.
Well, I see no t2018-checkout-branch.sh yet. What file do you suggest
appending?
On Fri, Jul 30, 2010 at 01:36:13AM +0200, Thomas Rast wrote:
> It should also use test_expect_failure unless you expect to have a fix
> soon, otherwise it would stop the test suite from running through.
Of course I'd like to have this bug fixed, but OK, let it be
test_expect_failure() for now.
--
ldv
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-07-30 8:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 22:01 [PATCH] checkout: add a test for creating a new branch with regexp as a starting point Dmitry V. Levin
2010-07-29 23:07 ` Ævar Arnfjörð Bjarmason
2010-07-29 23:36 ` Thomas Rast
2010-08-02 21:04 ` Junio C Hamano
2010-07-30 8:44 ` Dmitry V. Levin [this message]
2010-07-30 11:54 ` Ævar Arnfjörð Bjarmason
2010-07-30 19:13 ` When to use test_commit (Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point) Jonathan Nieder
2010-07-30 20:20 ` Ævar Arnfjörð Bjarmason
2010-07-31 0:18 ` [PATCH 1/2] test-lib.sh: introduce 4th argument to test_commit() specifying a tag name Dmitry V. Levin
2010-07-31 0:39 ` Ævar Arnfjörð Bjarmason
2010-07-31 1:56 ` [PATCH 1/2 v2] " Dmitry V. Levin
2010-07-31 10:23 ` Ævar Arnfjörð Bjarmason
2010-07-31 0:19 ` [PATCH 2/2] checkout: add a test for creating a new branch with regexp as a starting point Dmitry V. Levin
2010-07-31 0:44 ` Ævar Arnfjörð Bjarmason
2010-07-31 1:44 ` [PATCH 2/2 v2] " Dmitry V. Levin
2010-07-31 10:24 ` Ævar Arnfjörð Bjarmason
2010-08-05 21:24 ` [PATCH 2/2 v3] " Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730084428.GA9577@wo.int.altlinux.org \
--to=ldv@altlinux$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox