Subject: Re: [PATCH 07/12] bundle: run setup_git_directory_gently() sooner

From: Jonathan Nieder <[email-masked]>
Date: Mon, 16 Aug 2010 03:07:09 -0500

On Mon, Aug 16, 2010 at 09:21:32AM +0200, Thomas Rast wrote:
> Jonathan Nieder wrote:

>> +test_expect_success 'configuration can enable pager (from subdir)' '
[...]
>> +		test_terminal git bundle unbundle ../test.bundle
[...]
> On my valgrind test setup, this never worked (i.e., fails and bisects
> to this commit).

Agh, sloppy me...  Fixes below.

> Oddly, I am seeing this error message from the second test (second in
> t7006, not in this patch):
[...]
>   Can't locate IO/Pty.pm in @INC (@INC contains: <snip>) at /local/home/trast/git/t/t7006/test-terminal.perl line 4.
>   BEGIN failed--compilation aborted at /local/home/trast/git/t/t7006/test-terminal.perl line 4.
>   ok 2 - set up terminal for tests
> 
> Which raises a few questions: Why was this never an issue before?

That’s expected behavior, marked with “ok”. :)  That test is checking
if IO::Pty is available and works; if not, the relevant tests should
be skipped.

> does the test need a prerequisite other than HAVE_PERL?4

Exactly.

Jonathan Nieder (2):
  t7006 (pager): add missing TTY prerequisite
  t7006 (pager): add missing TTY prerequisite

 t/t7006-pager.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)