From: Jonathan Nieder <jrnieder@gmail•com>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: "Git Mailing List" <git@vger•kernel.org>,
"Junio C Hamano" <gitster@pobox•com>,
"Matthias Lederhofer" <matled@gmx•net>,
"Jürgen Rühle" <j-r@online•de>, "Eric Blake" <eblake@redhat•com>
Subject: Re: Fix 'git log' early pager startup error case
Date: Tue, 24 Aug 2010 20:36:25 -0500 [thread overview]
Message-ID: <20100825013625.GC10423@burratino> (raw)
In-Reply-To: <alpine.LFD.2.00.1008241029530.1046@i5.linux-foundation.org>
Linus Torvalds wrote:
> I dunno. I noticed this as a result of a typo, and some (un)happy timing
> ("less" will still start up as a pager if the input is delayed a bit). I
> think this is the right thing to do, but as mentioned, I only fixed a
> particular small error case.
I like it.
FWIW the change this undoes is v1.4.2-rc3~25^2~1 (Builtins: control
the use of pager from the command table., 2006-07-31). [1]
> AFAICS Matthias' patch has the added benefit of moving setup_pager to
> before large files (i.e. packs) are mapped. This helps non-COW-fork
> (i.e. cygwin) tremendously. Actually with Linus' setup refactoring
> this could probably be easily moved to the wrapper,...
Mingw Git uses spawnvpe now, but Cygwin users might still suffer from
fork() troubles. I think it should be possible to work around that by
using posix_spawn() from start_command() on such platforms (or
someting similar).
[1] http://thread.gmane.org/gmane.comp.version-control.git/24438/focus=24507
next prev parent reply other threads:[~2010-08-25 1:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 17:33 Fix 'git log' early pager startup error case Linus Torvalds
2010-08-25 1:36 ` Jonathan Nieder [this message]
2010-08-25 7:00 ` Johannes Sixt
2010-08-25 14:22 ` Eric Blake
2010-08-26 6:18 ` setting working dir in posix_spawn() (Re: Fix 'git log' early pager startup error case) Jonathan Nieder
2010-08-26 7:16 ` Joshua Juran
2010-08-26 14:13 ` Eric Blake
2010-08-25 19:16 ` Fix 'git log' early pager startup error case Junio C Hamano
2010-08-25 20:05 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825013625.GC10423@burratino \
--to=jrnieder@gmail$(echo .)com \
--cc=eblake@redhat$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j-r@online$(echo .)de \
--cc=matled@gmx$(echo .)net \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox