Subject: Re: [PATCH 2/2] Allow core.askpass to override SSH_ASKPASS.

From: Knut Franke <[email-masked]>
Date: Fri, 27 Aug 2010 14:45:24 +0200

On Friday 27 August 2010 14:00:16 Erik Faye-Lund wrote:
> > From: Knut Franke <[email-masked]>
>
> You don't need this line unless you're forwarding a patch for someone
> else (or using a different e-mail account).

ACK.

> > Modify handling of the 'core.askpass' option so that it has the same
> > effect as GIT_ASKPASS also if SSH_ASKPASS is set.
>
> Why are you sending a two-patch series where the second patch tries to
> correct the first one? Wouldn't it make more sense to squash the two?

a) The author of the first patch is on holiday, and I didn't want to pass off 
his work as mine nor my mistakes as his. ;-)

b) Maybe not everyone agrees about the correct order of precedence.

> > diff --git a/connect.c b/connect.c
> > index e296bfc..f97b84c 100644
> > --- a/connect.c
> > +++ b/connect.c
> > @@ -627,9 +627,13 @@ char *git_getpass(const char *prompt)
> >        static struct strbuf buffer = STRBUF_INIT;
> >
> >        askpass = getenv("GIT_ASKPASS");
> > +
>
> Why?

Considering the check for SSH_ASKPASS added below, I believe this improves 
legibilty since all of the "if (!askpass..." blocks are similar in intention.

-- 
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Dr. Roland Niemeier, 
Dr. Arno Steitz, Dr. Ingrid Zech
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Michel Lepert
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196