From: Heiko Voigt <hvoigt@hvoigt•net>
To: Jens Lehmann <Jens.Lehmann@web•de>
Cc: Junio C Hamano <gitster@pobox•com>,
Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH] t7405: cd inside subshell instead of around
Date: Thu, 2 Sep 2010 18:29:36 +0200 [thread overview]
Message-ID: <20100902162936.GA2535@book.hvoigt.net> (raw)
In-Reply-To: <4C7EBF3D.9030806@web.de>
On Wed, Sep 01, 2010 at 11:01:49PM +0200, Jens Lehmann wrote:
> Instead of using `cd dir && (...) && cd..` use `(cd dir && ...)`
>
> This ensures that the test doesn't get caught in the subdirectory if there
> is an error in the subshell.
>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web•de>
That makes the test way more robust, I like it.
cheers Heiko
prev parent reply other threads:[~2010-09-02 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 21:01 [PATCH] t7405: cd inside subshell instead of around Jens Lehmann
2010-09-02 16:29 ` Heiko Voigt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902162936.GA2535@book.hvoigt.net \
--to=hvoigt@hvoigt$(echo .)net \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox