From: Jakub Narebski <jnareb@gmail•com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCHv5 01/12] gitweb: introduce remote_heads feature
Date: Sun, 26 Sep 2010 19:24:05 +0200 [thread overview]
Message-ID: <201009261924.06237.jnareb@gmail.com> (raw)
In-Reply-To: <1285344167-8518-2-git-send-email-giuseppe.bilotta@gmail.com>
On Fri, 24 Sep 2010, Giuseppe Bilotta wrote:
> With this feature enabled, remotes are retrieved (and displayed)
> when getting (and displaying) the heads list. Typical usage would be for
> local repository browsing, e.g. by using git-instaweb (or even a more
> permanent gitweb setup), to check the repository status and the relation
> between tracking branches and the originating remotes.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail•com>
Nice and straighforward. For what it is worth:
Acked-by: Jakub Narebski <jnareb@gmail•com>
> ---
> gitweb/gitweb.perl | 18 ++++++++++++++++--
> 1 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index a85e2f6..f09fcee 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -486,6 +486,18 @@ our %feature = (
> 'sub' => sub { feature_bool('highlight', @_) },
> 'override' => 0,
> 'default' => [0]},
> +
> + # Make gitweb show remotes too in the heads list
Very minor nitpick: it should probably be (but I am not a native
English speaker, so I migh be mistaken)
+ # Make gitweb show also remotes in the heads list
> +
> + # To enable system wide have in $GITWEB_CONFIG
> + # $feature{'remote_heads'}{'default'} = [1];
> + # To have project specific config enable override in $GITWEB_CONFIG
> + # $feature{'remote_heads'}{'override'} = 1;
> + # and in project config gitweb.remote_heads = 0|1;
> + 'remote_heads' => {
> + 'sub' => sub { feature_bool('remote_heads', @_) },
> + 'override' => 0,
> + 'default' => [0]},
[...]
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-09-26 17:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 16:02 [PATCHv5 00/12] gitweb: remote_heads feature Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 01/12] gitweb: introduce " Giuseppe Bilotta
2010-09-26 17:24 ` Jakub Narebski [this message]
2010-09-26 19:19 ` Ævar Arnfjörð Bjarmason
2010-09-26 19:47 ` David Ripton
2010-09-27 6:42 ` Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 02/12] gitweb: git_get_heads_list accepts an optional list of refs Giuseppe Bilotta
2010-09-26 17:27 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 03/12] gitweb: separate heads and remotes lists Giuseppe Bilotta
2010-09-26 17:39 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 04/12] gitweb: nagivation menu for tags, heads and remotes Giuseppe Bilotta
2010-09-26 17:52 ` Jakub Narebski
2010-09-27 6:48 ` Giuseppe Bilotta
2010-09-27 8:30 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 05/12] gitweb: use fullname as hash_base in heads link Giuseppe Bilotta
2010-09-26 17:57 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 06/12] gitweb: allow extra text after action in page header Giuseppe Bilotta
2010-09-26 18:11 ` Jakub Narebski
2010-09-27 6:56 ` Giuseppe Bilotta
2010-09-27 7:42 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 07/12] gitweb: remotes view for a single remote Giuseppe Bilotta
2010-09-26 20:55 ` Jakub Narebski
2010-09-27 7:11 ` Giuseppe Bilotta
2010-09-27 7:53 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 08/12] gitweb: auxiliary function to group data Giuseppe Bilotta
2010-09-26 21:47 ` Jakub Narebski
2010-09-27 7:26 ` Giuseppe Bilotta
2010-09-27 8:12 ` Jakub Narebski
2010-09-27 19:17 ` Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 09/12] gitweb: group styling Giuseppe Bilotta
2010-09-26 22:10 ` Jakub Narebski
2010-09-27 7:27 ` Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 10/12] gitweb: git_repo_url() routine Giuseppe Bilotta
2010-09-26 22:34 ` Jakub Narebski
2010-09-27 7:29 ` Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 11/12] gitweb: use git_repo_url() in summary Giuseppe Bilotta
2010-09-26 22:36 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 12/12] gitweb: gather more remote data Giuseppe Bilotta
2010-09-27 15:47 ` Jakub Narebski
2010-10-23 16:17 ` Giuseppe Bilotta
2010-09-26 18:18 ` [PATCHv5 00/12] gitweb: remote_heads feature Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009261924.06237.jnareb@gmail.com \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=giuseppe.bilotta@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox